[lm-sensors] 2.10.1: No rule to make target `asm/io.h',

[lm-sensors] 2.10.1: No rule to make target `asm/io.h',

[Axel Thimm]

Hi,

I've been rebuilding packages for i2c/lm_sensors 2.10.1 and all build
fine, only not for the upcoming FC6 release:

gcc -M -MG -I. -Ikernel/include -I/usr/include  -DSYSFS_SUPPORT -fpic -Wall -O2  lib/general.c | \
        sed -e 's@^\(.*\)\.o:@lib/general.ld lib/general.lo: Makefile '`dirname lib/general.ld`/Module.mk' @' > lib/general.ld
gcc -M -MG -I. -Ikernel/include -I/usr/include  -DSYSFS_SUPPORT -fpic -Wall -O2  lib/data.c | \
        sed -e 's@^\(.*\)\.o:@lib/data.ld lib/data.lo: Makefile '`dirname lib/data.ld`/Module.mk' @' > lib/data.ld
( grep 'SENSORS SYSCTL START' /dev/null kernel/chips/*.c | \
          sed -e 's/:.*//' -e 's#^#kernel/include/sensors.h: #' ) > kernel/include/sensors.hd
cat kernel/include/sensors.h.template > kernel/include/sensors.h
awk '/SENSORS SYSCTL START/,/SENSORS SYSCTL END/' kernel/chips/*.c >> kernel/include/sensors.h
echo '#endif' >> kernel/include/sensors.h
gcc -M -MG -DETCDIR="\"/etc\"" -I. -Ikernel/include -I/usr/include  -Wundef -Wall -O2  prog/sensord/chips.c | \
        sed -e 's@^\(.*\)\.o:@prog/sensord/chips.rd prog/sensord/chips.ro: Makefile '`dirname prog/sensord/chips.rd`/Module.mk' @' > prog/sensord/chips.rd
gcc -M -MG -DETCDIR="\"/etc\"" -I. -Ikernel/include -I/usr/include  -Wundef -Wall -O2  prog/sensors/chips.c | \
        sed -e 's@^\(.*\)\.o:@prog/sensors/chips.rd prog/sensors/chips.ro: Makefile '`dirname prog/sensors/chips.rd`/Module.mk' @' > prog/sensors/chips.rd
make: *** No rule to make target `asm/io.h', needed by `prog/dump/isadump.rd'.  Stop.

-- 
Axel.Thimm at ATrpms.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20060926/3db86ba7/attachment.bin 

[lm-sensors] 2.10.1: No rule to make target `asm/io.h',

[Jean Delvare]

Hi Axel,

> I've been rebuilding packages for i2c/lm_sensors 2.10.1 and all build
> fine, only not for the upcoming FC6 release:
> 
> gcc -M -MG -I. -Ikernel/include -I/usr/include  -DSYSFS_SUPPORT -fpic -Wall -O2  lib/general.c | \
>         sed -e 's@^\(.*\)\.o:@lib/general.ld lib/general.lo: Makefile '`dirname lib/general.ld`/Module.mk' @' > lib/general.ld
> gcc -M -MG -I. -Ikernel/include -I/usr/include  -DSYSFS_SUPPORT -fpic -Wall -O2  lib/data.c | \
>         sed -e 's@^\(.*\)\.o:@lib/data.ld lib/data.lo: Makefile '`dirname lib/data.ld`/Module.mk' @' > lib/data.ld
> ( grep 'SENSORS SYSCTL START' /dev/null kernel/chips/*.c | \
>           sed -e 's/:.*//' -e 's#^#kernel/include/sensors.h: #' ) > kernel/include/sensors.hd
> cat kernel/include/sensors.h.template > kernel/include/sensors.h
> awk '/SENSORS SYSCTL START/,/SENSORS SYSCTL END/' kernel/chips/*.c >> kernel/include/sensors.h
> echo '#endif' >> kernel/include/sensors.h
> gcc -M -MG -DETCDIR="\"/etc\"" -I. -Ikernel/include -I/usr/include  -Wundef -Wall -O2  prog/sensord/chips.c | \
>         sed -e 's@^\(.*\)\.o:@prog/sensord/chips.rd prog/sensord/chips.ro: Makefile '`dirname prog/sensord/chips.rd`/Module.mk' @' > prog/sensord/chips.rd
> gcc -M -MG -DETCDIR="\"/etc\"" -I. -Ikernel/include -I/usr/include  -Wundef -Wall -O2  prog/sensors/chips.c | \
>         sed -e 's@^\(.*\)\.o:@prog/sensors/chips.rd prog/sensors/chips.ro: Makefile '`dirname prog/sensors/chips.rd`/Module.mk' @' > prog/sensors/chips.rd
> make: *** No rule to make target `asm/io.h', needed by `prog/dump/isadump.rd'.  Stop.

Where were you when I asked for testers before the release? :p

What architecture are you building for?

asm/io.h should be /usr/include/asm/io.h, don't you have that file?
Maybe you're missing the /usr/include/asm symlink to the arch-specific
asm directory?

-- 
Jean Delvare

[lm-sensors] 2.10.1: No rule to make target `asm/io.h',

[Axel Thimm]

On Tue, Sep 26, 2006 at 07:12:53PM +0200, Jean Delvare wrote:
> Hi Axel,
> 
> > I've been rebuilding packages for i2c/lm_sensors 2.10.1 and all build
> > fine, only not for the upcoming FC6 release:
> > 
> > gcc -M -MG -I. -Ikernel/include -I/usr/include  -DSYSFS_SUPPORT -fpic -Wall -O2  lib/general.c | \
> >         sed -e 's@^\(.*\)\.o:@lib/general.ld lib/general.lo: Makefile '`dirname lib/general.ld`/Module.mk' @' > lib/general.ld
> > gcc -M -MG -I. -Ikernel/include -I/usr/include  -DSYSFS_SUPPORT -fpic -Wall -O2  lib/data.c | \
> >         sed -e 's@^\(.*\)\.o:@lib/data.ld lib/data.lo: Makefile '`dirname lib/data.ld`/Module.mk' @' > lib/data.ld
> > ( grep 'SENSORS SYSCTL START' /dev/null kernel/chips/*.c | \
> >           sed -e 's/:.*//' -e 's#^#kernel/include/sensors.h: #' ) > kernel/include/sensors.hd
> > cat kernel/include/sensors.h.template > kernel/include/sensors.h
> > awk '/SENSORS SYSCTL START/,/SENSORS SYSCTL END/' kernel/chips/*.c >> kernel/include/sensors.h
> > echo '#endif' >> kernel/include/sensors.h
> > gcc -M -MG -DETCDIR="\"/etc\"" -I. -Ikernel/include -I/usr/include  -Wundef -Wall -O2  prog/sensord/chips.c | \
> >         sed -e 's@^\(.*\)\.o:@prog/sensord/chips.rd prog/sensord/chips.ro: Makefile '`dirname prog/sensord/chips.rd`/Module.mk' @' > prog/sensord/chips.rd
> > gcc -M -MG -DETCDIR="\"/etc\"" -I. -Ikernel/include -I/usr/include  -Wundef -Wall -O2  prog/sensors/chips.c | \
> >         sed -e 's@^\(.*\)\.o:@prog/sensors/chips.rd prog/sensors/chips.ro: Makefile '`dirname prog/sensors/chips.rd`/Module.mk' @' > prog/sensors/chips.rd
> > make: *** No rule to make target `asm/io.h', needed by `prog/dump/isadump.rd'.  Stop.
> 
> Where were you when I asked for testers before the release? :p

:)

> What architecture are you building for?

Happens for i386 and x86_64

> asm/io.h should be /usr/include/asm/io.h, don't you have that file?
> Maybe you're missing the /usr/include/asm symlink to the arch-specific
> asm directory?

No, it looks like /usr/include/asm/io.h was recently dropped.
-- 
Axel.Thimm at ATrpms.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20060926/94db5f0e/attachment.bin 

[lm-sensors] 2.10.1: No rule to make target `asm/io.h',

[Axel Thimm]

On Tue, Sep 26, 2006 at 08:37:52PM +0200, Axel Thimm wrote:
> On Tue, Sep 26, 2006 at 07:12:53PM +0200, Jean Delvare wrote:
> > > I've been rebuilding packages for i2c/lm_sensors 2.10.1 and all build
> > > fine, only not for the upcoming FC6 release:
> > > 
> > > gcc -M -MG -I. -Ikernel/include -I/usr/include  -DSYSFS_SUPPORT -fpic -Wall -O2  lib/general.c | \
> > >         sed -e 's@^\(.*\)\.o:@lib/general.ld lib/general.lo: Makefile '`dirname lib/general.ld`/Module.mk' @' > lib/general.ld
> > > gcc -M -MG -I. -Ikernel/include -I/usr/include  -DSYSFS_SUPPORT -fpic -Wall -O2  lib/data.c | \
> > >         sed -e 's@^\(.*\)\.o:@lib/data.ld lib/data.lo: Makefile '`dirname lib/data.ld`/Module.mk' @' > lib/data.ld
> > > ( grep 'SENSORS SYSCTL START' /dev/null kernel/chips/*.c | \
> > >           sed -e 's/:.*//' -e 's#^#kernel/include/sensors.h: #' ) > kernel/include/sensors.hd
> > > cat kernel/include/sensors.h.template > kernel/include/sensors.h
> > > awk '/SENSORS SYSCTL START/,/SENSORS SYSCTL END/' kernel/chips/*.c >> kernel/include/sensors.h
> > > echo '#endif' >> kernel/include/sensors.h
> > > gcc -M -MG -DETCDIR="\"/etc\"" -I. -Ikernel/include -I/usr/include  -Wundef -Wall -O2  prog/sensord/chips.c | \
> > >         sed -e 's@^\(.*\)\.o:@prog/sensord/chips.rd prog/sensord/chips.ro: Makefile '`dirname prog/sensord/chips.rd`/Module.mk' @' > prog/sensord/chips.rd
> > > gcc -M -MG -DETCDIR="\"/etc\"" -I. -Ikernel/include -I/usr/include  -Wundef -Wall -O2  prog/sensors/chips.c | \
> > >         sed -e 's@^\(.*\)\.o:@prog/sensors/chips.rd prog/sensors/chips.ro: Makefile '`dirname prog/sensors/chips.rd`/Module.mk' @' > prog/sensors/chips.rd
> > > make: *** No rule to make target `asm/io.h', needed by `prog/dump/isadump.rd'.  Stop.
> > 
> > Where were you when I asked for testers before the release? :p
> 
> :)
> 
> > What architecture are you building for?
> 
> Happens for i386 and x86_64
> 
> > asm/io.h should be /usr/include/asm/io.h, don't you have that file?
> > Maybe you're missing the /usr/include/asm symlink to the arch-specific
> > asm directory?
> 
> No, it looks like /usr/include/asm/io.h was recently dropped.

Ah, looking at the previous (current) release the contents of asm/io.h
are

| #ifndef _ASM_IO_H
| #define _ASM_IO_H
| 
| #warning <asm/io.h> is deprecated, use <sys/io.h> instead
| #include <sys/io.h>
| 
| #endif
-- 
Axel.Thimm at ATrpms.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20060926/15de9fbc/attachment.bin 

[lm-sensors] 2.10.1: No rule to make target `asm/io.h',

[Jean Delvare]

> > No, it looks like /usr/include/asm/io.h was recently dropped.
> 
> Ah, looking at the previous (current) release the contents of asm/io.h
> are
> 
> | #ifndef _ASM_IO_H
> | #define _ASM_IO_H
> | 
> | #warning <asm/io.h> is deprecated, use <sys/io.h> instead
> | #include <sys/io.h>
> | 
> | #endif

I found some posts along these lines on the web. However, I take that
you never saw this warning, because our code reads:

/* To keep glibc2 happy */
#if defined(__GLIBC__) && __GLIBC__ = 2 && __GLIBC_MINOR__ >= 0
#include <sys/io.h>
#else
#include <asm/io.h>
#endif

So it should look for sys/io.h rather than asm/io.h. It does for me.
I suspect that the test on __GLIBC__ somehow fails for you. Can you
please give a try to the following program?

--- 8< ---
#include <stdio.h>

int main()
{
	printf("__GLIBC__ = %d\n", __GLIBC__);
	printf("__GLIBC_MINOR__ = %d\n", __GLIBC_MINOR__);
	return 0;
}
--- 8< ---

$ gcc -Wall -W test_glibc.c -o test_glibc

I expect some surprise on your FC6 system.

That being said the test above looks bogus to me, the test on
__GLIBC_MINOR__ is useless as far as I can see, and the test will break
on GLIBC 3 for sure.

-- 
Jean Delvare

[lm-sensors] 2.10.1: No rule to make target `asm/io.h',

[Axel Thimm]

On Tue, Sep 26, 2006 at 08:56:48PM +0200, Jean Delvare wrote:
> > > No, it looks like /usr/include/asm/io.h was recently dropped.
> > 
> > Ah, looking at the previous (current) release the contents of asm/io.h
> > are
> > 
> > | #ifndef _ASM_IO_H
> > | #define _ASM_IO_H
> > | 
> > | #warning <asm/io.h> is deprecated, use <sys/io.h> instead
> > | #include <sys/io.h>
> > | 
> > | #endif
> 
> I found some posts along these lines on the web. However, I take that
> you never saw this warning, because our code reads:
> 
> /* To keep glibc2 happy */
> #if defined(__GLIBC__) && __GLIBC__ = 2 && __GLIBC_MINOR__ >= 0
> #include <sys/io.h>
> #else
> #include <asm/io.h>
> #endif
> 
> So it should look for sys/io.h rather than asm/io.h. It does for me.
> I suspect that the test on __GLIBC__ somehow fails for you. Can you
> please give a try to the following program?

I returns the expected result:

__GLIBC__ = 2
__GLIBC_MINOR__ = 4


> --- 8< ---
> #include <stdio.h>
> 
> int main()
> {
> 	printf("__GLIBC__ = %d\n", __GLIBC__);
> 	printf("__GLIBC_MINOR__ = %d\n", __GLIBC_MINOR__);
> 	return 0;
> }
> --- 8< ---
> 
> $ gcc -Wall -W test_glibc.c -o test_glibc
> 
> I expect some surprise on your FC6 system.
> 
> That being said the test above looks bogus to me, the test on
> __GLIBC_MINOR__ is useless as far as I can see, and the test will break
> on GLIBC 3 for sure.
> 

-- 
Axel.Thimm at ATrpms.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20060926/0d7861e3/attachment.bin 

[lm-sensors] 2.10.1: No rule to make target `asm/io.h',

[Jean Delvare]

Axel,

> On Tue, Sep 26, 2006 at 08:56:48PM +0200, Jean Delvare wrote:
> > > > No, it looks like /usr/include/asm/io.h was recently dropped.
> > > 
> > > Ah, looking at the previous (current) release the contents of asm/io.h
> > > are
> > > 
> > > | #ifndef _ASM_IO_H
> > > | #define _ASM_IO_H
> > > | 
> > > | #warning <asm/io.h> is deprecated, use <sys/io.h> instead
> > > | #include <sys/io.h>
> > > | 
> > > | #endif
> > 
> > I found some posts along these lines on the web. However, I take that
> > you never saw this warning, because our code reads:
> > 
> > /* To keep glibc2 happy */
> > #if defined(__GLIBC__) && __GLIBC__ = 2 && __GLIBC_MINOR__ >= 0
> > #include <sys/io.h>
> > #else
> > #include <asm/io.h>
> > #endif
> > 
> > So it should look for sys/io.h rather than asm/io.h. It does for me.
> > I suspect that the test on __GLIBC__ somehow fails for you. Can you
> > please give a try to the following program?
> 
> I returns the expected result:
> 
> __GLIBC__ = 2
> __GLIBC_MINOR__ = 4

Hmmm...

Can you try replacing in prog/dump/isadump.c:

/* To keep glibc2 happy */
#if defined(__GLIBC__) && __GLIBC__ = 2 && __GLIBC_MINOR__ >= 0
#include <sys/io.h>
#else
#include <asm/io.h>
#endif

With simply:

#include <sys/io.h>

And report? I'd like to make sure it's that part of the code causing
problem.

(You'll need to do the same in superio.c and isaset.c if it works.)

If it doesn't help, please provide the preprocessed output:

gcc -I. -E prog/dump/isadump.c -o prog/dump/isadump.E

Thanks,
-- 
Jean Delvare

[lm-sensors] 2.10.1: No rule to make target `asm/io.h',

[Axel Thimm]

On Tue, Sep 26, 2006 at 10:17:03PM +0200, Jean Delvare wrote:
> > On Tue, Sep 26, 2006 at 08:56:48PM +0200, Jean Delvare wrote:
> > > > > No, it looks like /usr/include/asm/io.h was recently dropped.

> > > So it should look for sys/io.h rather than asm/io.h. It does for me.

Well, on second look even sys/io.h is now missing. And this is for
both FC6 and RHEL5. :(
-- 
Axel.Thimm at ATrpms.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20060930/c6b967d6/attachment.bin 

[lm-sensors] 2.10.1: No rule to make target `asm/io.h',

[Axel Thimm]

On Sat, Sep 30, 2006 at 07:17:36PM +0200, Axel Thimm wrote:
> On Tue, Sep 26, 2006 at 10:17:03PM +0200, Jean Delvare wrote:
> > > On Tue, Sep 26, 2006 at 08:56:48PM +0200, Jean Delvare wrote:
> > > > > > No, it looks like /usr/include/asm/io.h was recently dropped.
> 
> > > > So it should look for sys/io.h rather than asm/io.h. It does for me.
> 
> Well, on second look even sys/io.h is now missing. And this is for
> both FC6 and RHEL5. :(

And on third look it looks like the headers were reshuffled throughout
the packages w/o fixing the lm_sensors package. So the headers do
exist and source builds work fine but the vendor packages are
broken. I'll respin packages for ATrpms.
-- 
Axel.Thimm at ATrpms.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20061001/789281f4/attachment.bin