* [patch 2.6.18-git] RTC class uses subsys_init
@ 2006-09-29 6:33 David Brownell
2006-09-30 15:44 ` Oleg Verych
2006-10-01 9:07 ` Olaf Hering
0 siblings, 2 replies; 6+ messages in thread
From: David Brownell @ 2006-09-29 6:33 UTC (permalink / raw)
To: Alessandro Zummo; +Cc: Linux Kernel list, Andrew Morton
[RESEND]
This makes RTC core components use "subsys_init" instead of "module_init",
as appropriate for subsystem infrastructure. This is mostly useful for
statically linking drivers in other parts of the tree that may provide an
RTC interface as a secondary functionality (e.g. part of a multifunction
chip); they won't need to worry so much about drivers/Makefile link order.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Index: linux/drivers/rtc/class.c
===================================================================
--- linux.orig/drivers/rtc/class.c 2006-07-30 16:08:47.000000000 -0700
+++ linux/drivers/rtc/class.c 2006-07-30 16:15:50.000000000 -0700
@@ -142,9 +142,9 @@
class_destroy(rtc_class);
}
-module_init(rtc_init);
+subsys_initcall(rtc_init);
module_exit(rtc_exit);
-MODULE_AUTHOR("Alessandro Zummo <a.zummo@towerteh.it>");
+MODULE_AUTHOR("Alessandro Zummo <a.zummo@towertech.it>");
MODULE_DESCRIPTION("RTC class support");
MODULE_LICENSE("GPL");
Index: linux/drivers/rtc/rtc-dev.c
===================================================================
--- linux.orig/drivers/rtc/rtc-dev.c 2006-07-30 16:08:47.000000000 -0700
+++ linux/drivers/rtc/rtc-dev.c 2006-07-30 16:15:50.000000000 -0700
@@ -496,7 +496,7 @@
unregister_chrdev_region(rtc_devt, RTC_DEV_MAX);
}
-module_init(rtc_dev_init);
+subsys_initcall(rtc_dev_init);
module_exit(rtc_dev_exit);
MODULE_AUTHOR("Alessandro Zummo <a.zummo@towertech.it>");
Index: linux/drivers/rtc/rtc-proc.c
===================================================================
--- linux.orig/drivers/rtc/rtc-proc.c 2006-07-30 16:08:47.000000000 -0700
+++ linux/drivers/rtc/rtc-proc.c 2006-07-30 16:15:50.000000000 -0700
@@ -156,7 +156,7 @@
class_interface_unregister(&rtc_proc_interface);
}
-module_init(rtc_proc_init);
+subsys_initcall(rtc_proc_init);
module_exit(rtc_proc_exit);
MODULE_AUTHOR("Alessandro Zummo <a.zummo@towertech.it>");
Index: linux/drivers/rtc/rtc-sysfs.c
===================================================================
--- linux.orig/drivers/rtc/rtc-sysfs.c 2006-07-30 16:08:47.000000000 -0700
+++ linux/drivers/rtc/rtc-sysfs.c 2006-07-30 16:15:50.000000000 -0700
@@ -116,7 +116,7 @@
class_interface_unregister(&rtc_sysfs_interface);
}
-module_init(rtc_sysfs_init);
+subsys_init(rtc_sysfs_init);
module_exit(rtc_sysfs_exit);
MODULE_AUTHOR("Alessandro Zummo <a.zummo@towertech.it>");
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch 2.6.18-git] RTC class uses subsys_init
2006-09-29 6:33 [patch 2.6.18-git] RTC class uses subsys_init David Brownell
@ 2006-09-30 15:44 ` Oleg Verych
2006-10-01 9:07 ` Olaf Hering
1 sibling, 0 replies; 6+ messages in thread
From: Oleg Verych @ 2006-09-30 15:44 UTC (permalink / raw)
To: linux-kernel
On 2006-09-29, David Brownell <david-b@pacbell.net> wrote:
> [RESEND]
>
> This makes RTC core components use "subsys_init" instead of "module_init",
> as appropriate for subsystem infrastructure. This is mostly useful for
> statically linking drivers in other parts of the tree that may provide an
> RTC interface as a secondary functionality (e.g. part of a multifunction
> chip); they won't need to worry so much about drivers/Makefile link order.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
>
ACK
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch 2.6.18-git] RTC class uses subsys_init
2006-09-29 6:33 [patch 2.6.18-git] RTC class uses subsys_init David Brownell
2006-09-30 15:44 ` Oleg Verych
@ 2006-10-01 9:07 ` Olaf Hering
2006-10-01 9:20 ` Andrew Morton
1 sibling, 1 reply; 6+ messages in thread
From: Olaf Hering @ 2006-10-01 9:07 UTC (permalink / raw)
To: David Brownell; +Cc: Alessandro Zummo, Linux Kernel list, Andrew Morton
On Thu, Sep 28, David Brownell wrote:
> +++ linux/drivers/rtc/rtc-sysfs.c 2006-07-30 16:15:50.000000000 -0700
> @@ -116,7 +116,7 @@
> class_interface_unregister(&rtc_sysfs_interface);
> }
>
> -module_init(rtc_sysfs_init);
> +subsys_init(rtc_sysfs_init);
> module_exit(rtc_sysfs_exit);
subsys_init is not defined, but the change is in Linus tree now.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch 2.6.18-git] RTC class uses subsys_init
2006-10-01 9:07 ` Olaf Hering
@ 2006-10-01 9:20 ` Andrew Morton
2006-10-01 13:49 ` David Brownell
2006-10-01 20:32 ` Oleg Verych
0 siblings, 2 replies; 6+ messages in thread
From: Andrew Morton @ 2006-10-01 9:20 UTC (permalink / raw)
To: Olaf Hering; +Cc: David Brownell, Alessandro Zummo, Linux Kernel list
On Sun, 1 Oct 2006 11:07:17 +0200
Olaf Hering <olaf@aepfle.de> wrote:
> On Thu, Sep 28, David Brownell wrote:
>
>
> > +++ linux/drivers/rtc/rtc-sysfs.c 2006-07-30 16:15:50.000000000 -0700
> > @@ -116,7 +116,7 @@
> > class_interface_unregister(&rtc_sysfs_interface);
> > }
> >
> > -module_init(rtc_sysfs_init);
> > +subsys_init(rtc_sysfs_init);
> > module_exit(rtc_sysfs_exit);
>
> subsys_init is not defined, but the change is in Linus tree now.
doh. But it still compiled.
drivers/rtc/rtc-sysfs.c:119: warning: data definition has no type or storage class
drivers/rtc/rtc-sysfs.c:119: warning: type defaults to 'int' in declaration of 'subsys_init'
drivers/rtc/rtc-sysfs.c:119: warning: parameter names (without types) in function declaration
drivers/rtc/rtc-sysfs.c:110: warning: 'rtc_sysfs_init' defined but not used
I'll fix it up.
(Wonders how it passed runtime testing..)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-10-01 20:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-29 6:33 [patch 2.6.18-git] RTC class uses subsys_init David Brownell
2006-09-30 15:44 ` Oleg Verych
2006-10-01 9:07 ` Olaf Hering
2006-10-01 9:20 ` Andrew Morton
2006-10-01 13:49 ` David Brownell
2006-10-01 20:32 ` Oleg Verych
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.