Re: [PATCH][Take 3] VNC authentification

["Daniel P. Berrange" <berrange@redhat.com>]

On Thu, Oct 05, 2006 at 08:24:48AM +0900, Masami Watanabe wrote:
> Hi all,
> 
> My understanding of main_loop of vl.c was insufficient. 
> I have improved the point to have set the handler doubly.
> The protocol of protocol 3.3 and (UltraVNC's ?)3.4 did not actually
> need the response of the authentification type from the client.
> Therefore, protocol_authtype operated without being called.
> 
> I will post the take 4 patch after this.
> 
> The patch has limited  RFB protocol to 3.3 and 3.4.
> I also think that it should support 3.8 without being support 3.3 in
> the future.
> 
> However, Leaving like non authetification is not good.
> You will think the patch to be provisional action till then.

If you get the basic auth working correctly with RFB protocol 3.3,
IMHO, that will be sufficient for an initial commit to xen-unstable
because it is such a step forward over the current 'no auth'
situation. We can consider extending it to cover protocol 3.8
at a later date when we decide which other auth meachanisms
are particularly important.

> Another.
> ill the RFB protocol still keep evolving in the future?

Its been on 3.8 for a while & clients will negotiate a mutually
supported protocol version with the server, so no need to worry
about future protocol versions at this time.

Regards,
Dan
--
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|