From: "Daniel P. Berrange" <berrange@redhat.com>
To: Masami Watanabe <masami.watanabe@jp.fujitsu.com>
Cc: Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk>,
Anthony Liguori <aliguori@us.ibm.com>,
xen-devel@lists.xensource.com
Subject: Re: [PATCH][Take 4] VNC authentification
Date: Tue, 10 Oct 2006 14:11:16 +0100 [thread overview]
Message-ID: <20061010131116.GA22928@redhat.com> (raw)
In-Reply-To: <JJ2006100510281519.8208468@jp.fujitsu.com>
On Thu, Oct 05, 2006 at 10:28:15AM +0900, Masami Watanabe wrote:
> Hi all,
>
> This is take 4 on VNC authentification.
>
> The specification is as mentioned at
> http://lists.xensource.com/archives/html/xen-devel/2006-09/msg00666.html
> (However, password came to describe plain text)
>
> The difference is follows.
> - protocol_authtype() without the necessity was deleted.
> - The check on the protocol version was added.
> - And, some small modification.
The patch loooks good to me - unless Anthony spots any further issues in
the VNC auth code, I'd say this is worth commiting to xen-unstable.hg
whe 3.0.4 development opens up.
Regards,
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
next prev parent reply other threads:[~2006-10-10 13:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-04 23:24 [PATCH][Take 3] VNC authentification Masami Watanabe
2006-10-04 23:42 ` Daniel P. Berrange
2006-10-05 0:56 ` Anthony Liguori
2006-10-05 1:28 ` [PATCH][Take 4] " Masami Watanabe
2006-10-10 13:11 ` Daniel P. Berrange [this message]
2006-10-10 14:04 ` Anthony Liguori
2006-10-25 18:00 ` Daniel P. Berrange
2006-10-25 20:43 ` Keir Fraser
2006-10-25 21:23 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061010131116.GA22928@redhat.com \
--to=berrange@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=m+Ian.Pratt@cl.cam.ac.uk \
--cc=masami.watanabe@jp.fujitsu.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.