From: Steven Smith <sos22-xen@srcf.ucam.org>
To: Tetsu Yamamoto <yamamoto.tetsu@jp.fujitsu.com>
Cc: xen-devel@lists.xensource.com, sos22@srcf.ucam.org
Subject: Re: [PATCH] xm reboot/shutdown/sysrq to HVM domain
Date: Fri, 6 Oct 2006 10:59:03 +0100 [thread overview]
Message-ID: <20061006095902.GA2767@cam.ac.uk> (raw)
In-Reply-To: <4526005B.1020906@jp.fujitsu.com>
[-- Attachment #1.1: Type: text/plain, Size: 1103 bytes --]
> This patch enhances 'xm reboot'/'xm shutdown' commands to
> reboot/shutdown guest Linux on HVM domain as gracefully as para-Linux.
> In addtion, sysrq key signal can be sent to HVM domain by 'xm sysrq'
> command.
Thanks, that's really useful. I have a couple of comments about the
patch, though:
-- It looks like you had some problems with ctrl_alt_del(), and instead
used kill_proc(cad_pid, SIGINT, 1). What was the reason for this?
-- You've introduced a lot of #ifdefs into reboot.c. It might be
easier to just split the file in two; did you look at this at all?
-- You set reboot_module from within a xenbus transaction. I don't
think that's necessary, since xenbus_writes are supposed to be
atomic anyway.
-- Because of the way mkbuildtree works, you're going to create
symlinks from unmodified-drivers to all of the files in
linux-2.6-xen-sparse/drivers/core, rather than just to reboot.c.
It's a trivial aesthetic issue, but it'd be nice not to create lots
of useless symlinks.
Apart from that, it looks pretty reasonable.
Steven.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
[-- Attachment #2: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2006-10-06 9:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 7:06 [PATCH] xm reboot/shutdown/sysrq to HVM domain Tetsu Yamamoto
2006-10-06 9:59 ` Steven Smith [this message]
2006-10-10 7:43 ` Tetsu Yamamoto
[not found] ` <20061012105108.GA3056@cam.ac.uk>
2006-10-18 9:52 ` Tetsu Yamamoto
2006-10-27 9:54 ` Tetsu Yamamoto
2006-10-31 20:15 ` Steven Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061006095902.GA2767@cam.ac.uk \
--to=sos22-xen@srcf.ucam.org \
--cc=sos22@srcf.ucam.org \
--cc=xen-devel@lists.xensource.com \
--cc=yamamoto.tetsu@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.