[Drbd-dev] local-io-error parse error in drbd.conf

[Drbd-dev] local-io-error parse error in drbd.conf

[Montrose, Ernest]

[-- Attachment #1: Type: text/plain, Size: 104 bytes --]

Hi,
Is this configuration key word fully implemented yet?  It causes a parse
error for now.
 
EM--

[-- Attachment #2: Type: text/html, Size: 3635 bytes --]

Re: [Drbd-dev] local-io-error parse error in drbd.conf

[Philipp Reisner]

Am Mittwoch, 4. Oktober 2006 21:21 schrieb Montrose, Ernest:
> Hi,
> Is this configuration key word fully implemented yet?  It causes a parse
> error for now.
>

Hi Ernest,

I do not understand the question, I guess you mean:

  disk {
    on-io-error   detach;
  }

And drbdsetup tells us, that it will accept...

[root@wurzel:~]# drbdsetup help disk
USAGE:
 disk lower_dev meta_data_dev meta_data_index [{--size|-d} 0 ... 8587575296]
     [{--on-io-error|-e} pass_on call-local-io-error detach]
     [{--fencing|-f} dont-care resource-only resource-and-stonith] 
[{--use-bmbv|-b}]

pass_on, call-local-io-error or detach as values for on-io-error.

-Phil
-- 
: Dipl-Ing Philipp Reisner                      Tel +43-1-8178292-50 :
: LINBIT Information Technologies GmbH          Fax +43-1-8178292-82 :
: Schönbrunnerstr 244, 1120 Vienna, Austria    http://www.linbit.com :

RE: [Drbd-dev] local-io-error parse error in drbd.conf

[Montrose, Ernest]

Hi Phil,
OK I was not very clear.  It was a little late in the day so forgive me. Here are the details:

In /etc/drbd.conf I set:
handlers{
local-io-error "echo 0> /proc/sysrq-trigger; halt -f";
}

In disk I just have:
Disk{
on-io-error detach;
}

If I now do a "drbdadm -d state all" for example I get:
/etc/drbd.conf:31: Parse eror: 'an option keyword' expected,
 but got 'local-io-error'.

It seems like the implementation is in the driver but not in drbdsetup(1).

Thanks.

EM--
-----Original Message-----
From: drbd-dev-bounces@linbit.com [mailto:drbd-dev-bounces@linbit.com] On Behalf Of Philipp Reisner
Sent: Thursday, October 05, 2006 4:51 AM
To: drbd-dev@linbit.com
Subject: Re: [Drbd-dev] local-io-error parse error in drbd.conf

Am Mittwoch, 4. Oktober 2006 21:21 schrieb Montrose, Ernest:
> Hi,
> Is this configuration key word fully implemented yet?  It causes a parse
> error for now.
>

Hi Ernest,

I do not understand the question, I guess you mean:

  disk {
    on-io-error   detach;
  }

And drbdsetup tells us, that it will accept...

[root@wurzel:~]# drbdsetup help disk
USAGE:
 disk lower_dev meta_data_dev meta_data_index [{--size|-d} 0 ... 8587575296]
     [{--on-io-error|-e} pass_on call-local-io-error detach]
     [{--fencing|-f} dont-care resource-only resource-and-stonith] 
[{--use-bmbv|-b}]

pass_on, call-local-io-error or detach as values for on-io-error.

-Phil
-- 
: Dipl-Ing Philipp Reisner                      Tel +43-1-8178292-50 :
: LINBIT Information Technologies GmbH          Fax +43-1-8178292-82 :
: Schönbrunnerstr 244, 1120 Vienna, Austria    http://www.linbit.com :
_______________________________________________
drbd-dev mailing list
drbd-dev@lists.linbit.com
http://lists.linbit.com/mailman/listinfo/drbd-dev

Re: [Drbd-dev] local-io-error parse error in drbd.conf

[Philipp Reisner]

Am Donnerstag, 5. Oktober 2006 15:03 schrieb Montrose, Ernest:
> Hi Phil,
> OK I was not very clear.  It was a little late in the day so forgive me.
> Here are the details:
>
> In /etc/drbd.conf I set:
> handlers{
> local-io-error "echo 0> /proc/sysrq-trigger; halt -f";
> }
>
> In disk I just have:
> Disk{
> on-io-error detach;
> }
>
> If I now do a "drbdadm -d state all" for example I get:
> /etc/drbd.conf:31: Parse eror: 'an option keyword' expected,
>  but got 'local-io-error'.
>
> It seems like the implementation is in the driver but not in drbdsetup(1).
>
> Thanks.

Oh, yes right. You are right, I forgot to add this to drbdadm, and
to drbdadm's scanner/parser. I will do this on Friday, please comment 
the handler out of your config file in the mean time.

You should be able to see the event in the output of 
'drbdsetup /dev/drbd0 events -a'.

-Phil
-- 
: Dipl-Ing Philipp Reisner                      Tel +43-1-8178292-50 :
: LINBIT Information Technologies GmbH          Fax +43-1-8178292-82 :
: Schönbrunnerstr 244, 1120 Vienna, Austria    http://www.linbit.com :

Re: [Drbd-dev] local-io-error parse error in drbd.conf

[Philipp Reisner]

Am Donnerstag, 5. Oktober 2006 15:03 schrieb Montrose, Ernest:
> Hi Phil,
> OK I was not very clear.  It was a little late in the day so forgive me.
> Here are the details:
>
> In /etc/drbd.conf I set:
> handlers{
> local-io-error "echo 0> /proc/sysrq-trigger; halt -f";
> }
>
> In disk I just have:
> Disk{
> on-io-error detach;
> }
>
> If I now do a "drbdadm -d state all" for example I get:
> /etc/drbd.conf:31: Parse eror: 'an option keyword' expected,
>  but got 'local-io-error'.
>
> It seems like the implementation is in the driver but not in drbdsetup(1).
>

Thanks, for pointing it out. I have just commited the missing implementaion.
See http://lists.linbit.com/pipermail/drbd-cvs/2006-October/001305.html

-Phil
-- 
: Dipl-Ing Philipp Reisner                      Tel +43-1-8178292-50 :
: LINBIT Information Technologies GmbH          Fax +43-1-8178292-82 :
: Schönbrunnerstr 244, 1120 Vienna, Austria    http://www.linbit.com :