paginate git-diff by default?

paginate git-diff by default?

[Martin Waitz]

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]

hoi :)

I always find myself typing "git -p diff".
Should we paginate git-diff output by default?

I was sure this was discussed before but I could not immediately
find it, so I'm simply asking again ;-).

-- 
Martin Waitz

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: paginate git-diff by default?

[Shawn Pearce]

Martin Waitz <tali@admingilde.org> wrote:
> hoi :)
> 
> I always find myself typing "git -p diff".
> Should we paginate git-diff output by default?
> 
> I was sure this was discussed before but I could not immediately
> find it, so I'm simply asking again ;-).

I agree.  I'm very used to git log automatically running my $PAGER;
I'm always surprised that git diff doesn't do the same when attached
to my tty.

-- 
Shawn.

Re: paginate git-diff by default?

[Johannes Schindelin]

Hi,

On Tue, 10 Oct 2006, Martin Waitz wrote:

> I always find myself typing "git -p diff".

I don't. Because I have an alias "pd" for that on all of my machines. ;')

Ciao,
Dscho

[PATCH] paginate git-diff by default

[Martin Waitz]

On Tue, Oct 10, 2006 at 02:15:58PM -0400, Shawn Pearce wrote:
> Martin Waitz <tali@admingilde.org> wrote:
> > I always find myself typing "git -p diff".
> > Should we paginate git-diff output by default?
>
> I agree.  I'm very used to git log automatically running my $PAGER;
> I'm always surprised that git diff doesn't do the same when attached
> to my tty.

so here is the overly complex implementation:

---
diff --git a/git.c b/git.c
index 03acb25..3408e81 100644
--- a/git.c
+++ b/git.c
@@ -226,7 +226,7 @@ static void handle_internal_command(int
 		{ "check-ref-format", cmd_check_ref_format },
 		{ "commit-tree", cmd_commit_tree, RUN_SETUP },
 		{ "count-objects", cmd_count_objects, RUN_SETUP },
-		{ "diff", cmd_diff, RUN_SETUP },
+		{ "diff", cmd_diff, RUN_SETUP | USE_PAGER },
 		{ "diff-files", cmd_diff_files, RUN_SETUP },
 		{ "diff-index", cmd_diff_index, RUN_SETUP },
 		{ "diff-stages", cmd_diff_stages, RUN_SETUP },

-- 
Martin Waitz

Re: [PATCH] paginate git-diff by default

[Junio C Hamano]

Martin Waitz <tali@admingilde.org> writes:

> On Tue, Oct 10, 2006 at 02:15:58PM -0400, Shawn Pearce wrote:
>> Martin Waitz <tali@admingilde.org> wrote:
>> > I always find myself typing "git -p diff".
>> > Should we paginate git-diff output by default?
>>
>> I agree.  I'm very used to git log automatically running my $PAGER;
>> I'm always surprised that git diff doesn't do the same when attached
>> to my tty.

Hmm.  So close to 1.4.3...  Will take it.