From: Andrew Morton <akpm@osdl.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
sfr@canb.auug.org.au, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] lockdep: annotate i386 apm
Date: Thu, 12 Oct 2006 00:29:06 -0700 [thread overview]
Message-ID: <20061012002906.dd29c376.akpm@osdl.org> (raw)
In-Reply-To: <1160635850.2006.98.camel@taijtu>
On Thu, 12 Oct 2006 08:50:50 +0200
Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> Was my original _that_ hard to read?
The macro was bad enough. Then you want an added another one and made it
reference a caller's local variable. Another dummy-shaped dent in my wall.
I'd appreciate a fixed-up patch which changes the code's niceness in a
positive direction please - I'm obviously not cut out to work on apm.c.
next prev parent reply other threads:[~2006-10-12 7:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-11 13:40 [PATCH] lockdep: annotate i386 apm Peter Zijlstra
2006-10-11 21:18 ` Andrew Morton
2006-10-12 6:06 ` Peter Zijlstra
2006-10-12 6:39 ` Andrew Morton
2006-10-12 6:50 ` Peter Zijlstra
2006-10-12 7:29 ` Andrew Morton [this message]
2006-10-12 8:13 ` Peter Zijlstra
2006-10-12 8:02 ` Ingo Molnar
2006-10-12 8:26 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061012002906.dd29c376.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.