From: Stephen Hemminger <shemminger@osdl.org>
To: Andy Gospodarek <andy@greyhouse.net>
Cc: netdev@vger.kernel.org, bridge@osdl.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Bridge] [PATCH] bridge: flush forwarding table when device carrier off
Date: Thu, 12 Oct 2006 13:31:23 -0700 [thread overview]
Message-ID: <20061012133123.0a37c77d@freekitty> (raw)
In-Reply-To: <20061012201043.GA29253@gospo.rdu.redhat.com>
On Thu, 12 Oct 2006 16:10:44 -0400
Andy Gospodarek <andy@greyhouse.net> wrote:
> On Thu, Oct 12, 2006 at 11:24:31AM -0700, Stephen Hemminger wrote:
> > Flush the forwarding table when carrier is lost. This helps for
> > availability because we don't want to forward to a downed device and
> > new packets may come in on other links.
> >
> > Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
> >
>
> Stephen,
>
> This is an excellent idea and all looks good except this check
>
> + if (f->is_static & !do_all)
> + continue;
>
> should be this:
>
> + if (f->is_static && !do_all)
> + continue;
>
Agreed, but it probably worked during testing because both flags
are strict booleans (ie 0/1)
--
Stephen Hemminger <shemminger@osdl.org>
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <shemminger@osdl.org>
To: Andy Gospodarek <andy@greyhouse.net>
Cc: netdev@vger.kernel.org, bridge@osdl.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] bridge: flush forwarding table when device carrier off
Date: Thu, 12 Oct 2006 13:31:23 -0700 [thread overview]
Message-ID: <20061012133123.0a37c77d@freekitty> (raw)
In-Reply-To: <20061012201043.GA29253@gospo.rdu.redhat.com>
On Thu, 12 Oct 2006 16:10:44 -0400
Andy Gospodarek <andy@greyhouse.net> wrote:
> On Thu, Oct 12, 2006 at 11:24:31AM -0700, Stephen Hemminger wrote:
> > Flush the forwarding table when carrier is lost. This helps for
> > availability because we don't want to forward to a downed device and
> > new packets may come in on other links.
> >
> > Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
> >
>
> Stephen,
>
> This is an excellent idea and all looks good except this check
>
> + if (f->is_static & !do_all)
> + continue;
>
> should be this:
>
> + if (f->is_static && !do_all)
> + continue;
>
Agreed, but it probably worked during testing because both flags
are strict booleans (ie 0/1)
--
Stephen Hemminger <shemminger@osdl.org>
next prev parent reply other threads:[~2006-10-12 20:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-12 18:24 [Bridge] [PATCH] bridge: flush forwarding table when device carrier off Stephen Hemminger
2006-10-12 18:24 ` Stephen Hemminger
2006-10-12 20:10 ` [Bridge] " Andy Gospodarek
2006-10-12 20:10 ` Andy Gospodarek
2006-10-12 20:31 ` Stephen Hemminger [this message]
2006-10-12 20:31 ` Stephen Hemminger
2006-10-12 21:30 ` [Bridge] " jamal
2006-10-12 21:30 ` jamal
2006-10-12 21:32 ` [Bridge] " Stephen Hemminger
2006-10-12 21:32 ` Stephen Hemminger
2006-10-12 21:47 ` [Bridge] " jamal
2006-10-12 21:47 ` jamal
2006-10-12 21:48 ` [Bridge] " David Miller
2006-10-12 21:48 ` David Miller
2006-10-24 7:39 ` [Bridge] " ArcosCom Linux User
2006-10-24 7:39 ` ArcosCom Linux User
2006-10-24 8:29 ` David Miller
2006-10-24 8:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061012133123.0a37c77d@freekitty \
--to=shemminger@osdl.org \
--cc=andy@greyhouse.net \
--cc=bridge@osdl.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.