From: Nick Piggin <npiggin@suse.de>
To: Linux Memory Management <linux-mm@kvack.org>
Cc: Neil Brown <neilb@suse.de>, Andrew Morton <akpm@osdl.org>,
Anton Altaparmakov <aia21@cam.ac.uk>,
Chris Mason <chris.mason@oracle.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Nick Piggin <npiggin@suse.de>
Subject: [patch 1/6] mm: revert "generic_file_buffered_write(): handle zero length iovec segments"
Date: Fri, 13 Oct 2006 18:44:02 +0200 (CEST) [thread overview]
Message-ID: <20061013143526.15438.56911.sendpatchset@linux.site> (raw)
In-Reply-To: <20061013143516.15438.8802.sendpatchset@linux.site>
From: Andrew Morton <akpm@osdl.org>
Revert 81b0c8713385ce1b1b9058e916edcf9561ad76d6.
This was a bugfix against 6527c2bdf1f833cc18e8f42bd97973d583e4aa83, which we
also revert.
Signed-off-by: Andrew Morton <akpm@osdl.org>
Index: linux-2.6/mm/filemap.c
===================================================================
--- linux-2.6.orig/mm/filemap.c
+++ linux-2.6/mm/filemap.c
@@ -1912,12 +1912,6 @@ generic_file_buffered_write(struct kiocb
break;
}
- if (unlikely(bytes == 0)) {
- status = 0;
- copied = 0;
- goto zero_length_segment;
- }
-
status = a_ops->prepare_write(file, page, offset, offset+bytes);
if (unlikely(status)) {
loff_t isize = i_size_read(inode);
@@ -1947,8 +1941,7 @@ generic_file_buffered_write(struct kiocb
page_cache_release(page);
continue;
}
-zero_length_segment:
- if (likely(copied >= 0)) {
+ if (likely(copied > 0)) {
if (!status)
status = copied;
Index: linux-2.6/mm/filemap.h
===================================================================
--- linux-2.6.orig/mm/filemap.h
+++ linux-2.6/mm/filemap.h
@@ -87,7 +87,7 @@ filemap_set_next_iovec(const struct iove
const struct iovec *iov = *iovp;
size_t base = *basep;
- do {
+ while (bytes) {
int copy = min(bytes, iov->iov_len - base);
bytes -= copy;
@@ -96,7 +96,7 @@ filemap_set_next_iovec(const struct iove
iov++;
base = 0;
}
- } while (bytes);
+ }
*iovp = iov;
*basep = base;
}
WARNING: multiple messages have this Message-ID (diff)
From: Nick Piggin <npiggin@suse.de>
From: Andrew Morton <akpm@osdl.org>
To: Linux Memory Management <linux-mm@kvack.org>
Cc: Neil Brown <neilb@suse.de>, Andrew Morton <akpm@osdl.org>,
Anton Altaparmakov <aia21@cam.ac.uk>,
Chris Mason <chris.mason@oracle.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Nick Piggin <npiggin@suse.de>
Subject: [patch 1/6] mm: revert "generic_file_buffered_write(): handle zero length iovec segments"
Date: Fri, 13 Oct 2006 18:44:02 +0200 (CEST) [thread overview]
Message-ID: <20061013143526.15438.56911.sendpatchset@linux.site> (raw)
In-Reply-To: <20061013143516.15438.8802.sendpatchset@linux.site>
Revert 81b0c8713385ce1b1b9058e916edcf9561ad76d6.
This was a bugfix against 6527c2bdf1f833cc18e8f42bd97973d583e4aa83, which we
also revert.
Signed-off-by: Andrew Morton <akpm@osdl.org>
Index: linux-2.6/mm/filemap.c
===================================================================
--- linux-2.6.orig/mm/filemap.c
+++ linux-2.6/mm/filemap.c
@@ -1912,12 +1912,6 @@ generic_file_buffered_write(struct kiocb
break;
}
- if (unlikely(bytes == 0)) {
- status = 0;
- copied = 0;
- goto zero_length_segment;
- }
-
status = a_ops->prepare_write(file, page, offset, offset+bytes);
if (unlikely(status)) {
loff_t isize = i_size_read(inode);
@@ -1947,8 +1941,7 @@ generic_file_buffered_write(struct kiocb
page_cache_release(page);
continue;
}
-zero_length_segment:
- if (likely(copied >= 0)) {
+ if (likely(copied > 0)) {
if (!status)
status = copied;
Index: linux-2.6/mm/filemap.h
===================================================================
--- linux-2.6.orig/mm/filemap.h
+++ linux-2.6/mm/filemap.h
@@ -87,7 +87,7 @@ filemap_set_next_iovec(const struct iove
const struct iovec *iov = *iovp;
size_t base = *basep;
- do {
+ while (bytes) {
int copy = min(bytes, iov->iov_len - base);
bytes -= copy;
@@ -96,7 +96,7 @@ filemap_set_next_iovec(const struct iove
iov++;
base = 0;
}
- } while (bytes);
+ }
*iovp = iov;
*basep = base;
}
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-10-13 16:44 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-13 16:43 [rfc] buffered write deadlock fix Nick Piggin
2006-10-13 16:43 ` Nick Piggin
2006-10-13 16:44 ` Nick Piggin [this message]
2006-10-13 16:44 ` [patch 1/6] mm: revert "generic_file_buffered_write(): handle zero length iovec segments" Nick Piggin, Andrew Morton
2006-10-13 16:44 ` [patch 2/6] mm: revert "generic_file_buffered_write(): deadlock on vectored write" Nick Piggin
2006-10-13 16:44 ` Nick Piggin, Andrew Morton
2006-10-13 16:44 ` [patch 3/6] mm: generic_file_buffered_write cleanup Nick Piggin
2006-10-13 16:44 ` Nick Piggin, Andrew Morton
2006-10-13 16:44 ` [patch 4/6] mm: comment mmap_sem / lock_page lockorder Nick Piggin
2006-10-13 16:44 ` Nick Piggin
2006-10-13 16:44 ` [patch 5/6] mm: debug write deadlocks Nick Piggin
2006-10-13 16:44 ` Nick Piggin
2006-10-13 16:44 ` [patch 6/6] mm: fix pagecache " Nick Piggin
2006-10-13 16:44 ` Nick Piggin, Andrew Morton
2006-10-13 22:14 ` Andrew Morton
2006-10-13 22:14 ` Andrew Morton
2006-10-14 4:19 ` Nick Piggin
2006-10-14 4:19 ` Nick Piggin
2006-10-14 4:30 ` Nick Piggin
2006-10-14 4:30 ` Nick Piggin
2006-10-15 11:35 ` Peter Zijlstra
2006-10-15 11:35 ` Peter Zijlstra
2006-10-14 5:04 ` Nick Piggin
2006-10-14 5:04 ` Nick Piggin
2006-10-15 11:37 ` Peter Zijlstra
2006-10-15 11:37 ` Peter Zijlstra
2006-10-15 11:56 ` Nick Piggin
2006-10-15 11:56 ` Nick Piggin
2006-10-15 13:51 ` Peter Zijlstra
2006-10-15 13:51 ` Peter Zijlstra
2006-10-15 14:19 ` SPAM: " Nick Piggin
2006-10-15 14:19 ` Nick Piggin
2006-10-15 15:47 ` Peter Zijlstra
2006-10-15 15:47 ` Peter Zijlstra
2006-10-15 15:57 ` RRe: " Nick Piggin
2006-10-15 15:57 ` Nick Piggin
2006-10-15 16:13 ` Peter Zijlstra
2006-10-15 16:13 ` Peter Zijlstra
2006-10-16 15:24 ` pagefault_disable (was Re: [patch 6/6] mm: fix pagecache write deadlocks) Nick Piggin
2006-10-16 15:24 ` Nick Piggin
2006-10-16 16:05 ` Peter Zijlstra
2006-10-16 16:05 ` Peter Zijlstra
2006-10-16 16:12 ` Nick Piggin
2006-10-16 16:12 ` Nick Piggin
2006-10-18 14:25 ` [patch 6/6] mm: fix pagecache write deadlocks Chris Mason
2006-10-18 14:25 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061013143526.15438.56911.sendpatchset@linux.site \
--to=npiggin@suse.de \
--cc=aia21@cam.ac.uk \
--cc=akpm@osdl.org \
--cc=chris.mason@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.