LVM and RAID merged

LVM and RAID merged

[Yoshinori K. Okuji]

So I've merged the result by Jeroen into the main trunk. Please check it out, 
if you are interested.

BTW we haven't released a new version for a while. Thus I'd like to make one 
tomorrow. Does anybody have an objection? I think LVM and RAID support is 
good enough to announce a new version.

Okuji

Re: LVM and RAID merged

[Marco Gerards]

"Yoshinori K. Okuji" <okuji@enbug.org> writes:

> So I've merged the result by Jeroen into the main trunk. Please check it out, 
> if you are interested.


Great!  Thanks a lot for doing this!

> BTW we haven't released a new version for a while. Thus I'd like to make one 
> tomorrow. Does anybody have an objection? I think LVM and RAID support is 
> good enough to announce a new version.

Agreed.

--
Marco

Re: LVM and RAID merged

[Yoshinori K. Okuji]

On Saturday 14 October 2006 17:53, Marco Gerards wrote:
> "Yoshinori K. Okuji" <okuji@enbug.org> writes:
> > So I've merged the result by Jeroen into the main trunk. Please check it
> > out, if you are interested.
>
> Great!  Thanks a lot for doing this!

You should thank Jeroen instead. ;)

Okuji

Re: LVM and RAID merged

[Robert Millan]

On Sat, Oct 14, 2006 at 05:36:19PM +0200, Yoshinori K. Okuji wrote:
> So I've merged the result by Jeroen into the main trunk. Please check it out, 
> if you are interested.
> 
> BTW we haven't released a new version for a while. Thus I'd like to make one 
> tomorrow. Does anybody have an objection? I think LVM and RAID support is 
> good enough to announce a new version.

I've noticed this:

  ./grub2/util/i386/pc/getroot.c:  if (!strncmp (os_dev, "/dev/md", 7) || !strncmp (os_dev, "/dev/.static/dev/md", 19))

I think checking for /dev/.static is no longer needed because of:

2006-09-14  Robert Millan  <rmh@aybabtu.com>
[...]
	* util/i386/pc/getroot.c: Don't recurse into dotdirs (e.g. ".static").

Anyone can confirm that?  I don't have a RAID system for testing here.

-- 
Robert Millan

My spam trap is honeypot@aybabtu.com.  Note: this address is only intended for
spam harvesters.  Writing to it will get you added to my black list.

Re: LVM and RAID merged

[Jeroen Dekkers]

At Sat, 14 Oct 2006 21:08:05 +0200,
Robert Millan wrote:
> 
> On Sat, Oct 14, 2006 at 05:36:19PM +0200, Yoshinori K. Okuji wrote:
> > So I've merged the result by Jeroen into the main trunk. Please check it out, 
> > if you are interested.
> > 
> > BTW we haven't released a new version for a while. Thus I'd like to make one 
> > tomorrow. Does anybody have an objection? I think LVM and RAID support is 
> > good enough to announce a new version.
> 
> I've noticed this:
> 
>   ./grub2/util/i386/pc/getroot.c:  if (!strncmp (os_dev, "/dev/md", 7) || !strncmp (os_dev, "/dev/.static/dev/md", 19))
> 
> I think checking for /dev/.static is no longer needed because of:
> 
> 2006-09-14  Robert Millan  <rmh@aybabtu.com>
> [...]
> 	* util/i386/pc/getroot.c: Don't recurse into dotdirs (e.g. ".static").
> 
> Anyone can confirm that?  I don't have a RAID system for testing here.

That's correct, you can remove the second check.

Jeroen Dekkers

Re: LVM and RAID merged

[Jeroen Dekkers]

At Sat, 14 Oct 2006 17:36:19 +0200,
Yoshinori K. Okuji wrote:
> 
> So I've merged the result by Jeroen into the main trunk. Please check it out, 
> if you are interested.
> 
> BTW we haven't released a new version for a while. Thus I'd like to make one 
> tomorrow. Does anybody have an objection? I think LVM and RAID support is 
> good enough to announce a new version.

Thanks for the merge. I don't have time to hack on it at the moment,
but the LVM and RAID module don't have debugging printfs in it. So
this will make it hard to debug problems that people might have with
it.

Jeroen Dekkers