* [PATCH 2.6.19-rc2] drivers/usb/serial/mos7840.c: check kmalloc() return value.
@ 2006-10-16 7:40 Amit Choudhary
0 siblings, 0 replies; only message in thread
From: Amit Choudhary @ 2006-10-16 7:40 UTC (permalink / raw)
To: Linux Kernel
Description: Check the return value of kmalloc() in function mos7840_get_reg(), in file drivers/usb/serial/mos7840.c.
Signed-off-by: Amit Choudhary <amit2030@gmail.com>
diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
index 021be39..91d474b 100644
--- a/drivers/usb/serial/mos7840.c
+++ b/drivers/usb/serial/mos7840.c
@@ -475,6 +475,14 @@ static int mos7840_get_reg(struct moschi
int ret = 0;
buffer = (__u8 *) mcs->ctrl_buf;
+ /* The memory for ctrl_buf is allocated in
+ * mos7840_startup(), but it is not checked if
+ * kmalloc failed. So, mcs->ctrl_buf might be NULL.
+ * So, it should be checked here.
+ */
+ if (!buffer)
+ return -ENOMEM;
+
// dr=(struct usb_ctrlrequest *)(buffer);
dr = (void *)(buffer + 2);
dr->bRequestType = MCS_RD_RTYPE;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2006-10-16 7:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-16 7:40 [PATCH 2.6.19-rc2] drivers/usb/serial/mos7840.c: check kmalloc() return value Amit Choudhary
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.