From: Michael Buesch <mb@bu3sch.de>
To: "Simon Barber" <simon@devicescape.com>
Cc: "David Kimdon" <dwhedon@devicescape.com>,
netdev@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
"Jiri Benc" <jbenc@suse.cz>
Subject: Re: [patch 1/5] d80211: remove bitfields from ieee80211_tx_control
Date: Mon, 16 Oct 2006 22:05:35 +0200 [thread overview]
Message-ID: <200610162205.35649.mb@bu3sch.de> (raw)
In-Reply-To: <C86180A8C204554D8A3323D8F6B0A29F01851A93@dhost002-46.dex002.intermedia.net>
On Monday 16 October 2006 21:34, Simon Barber wrote:
> Removing the bitfields makes the code much harder to read and maintain.
> Here we are working around a problem with the compiler by making the
> code ugly - rather than fixing the compiler. The compilers are getting
> better and better (GCC 4 has much better handling of this type of
> optimization) but the code will remain ugly for ever.
Yeah, that's my opinion on this, too.
But I still like the unsigned int foo:16; => u16 foo; type of conversions.
--
Greetings Michael.
next prev parent reply other threads:[~2006-10-16 20:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061013191910.297963000@devicescape.com>
2006-10-13 19:20 ` [patch 1/5] d80211: remove bitfields from ieee80211_tx_control David Kimdon
2006-10-16 16:07 ` Michael Buesch
2006-10-16 19:34 ` Simon Barber
2006-10-16 20:05 ` Michael Buesch [this message]
2006-10-17 17:26 ` David Kimdon
2006-10-17 17:19 ` David Kimdon
2006-10-13 19:20 ` [patch 2/5] d80211: remove bitfields from ieee80211_tx_status David Kimdon
2006-10-13 19:21 ` [patch 3/5] d80211: remove bitfields from ieee80211_key_conf David Kimdon
2006-10-13 19:21 ` [patch 4/5] d80211: remove bitfields from ieee80211_hw David Kimdon
2006-10-13 19:21 ` [patch 5/5] d80211: remove bitfields from ieee80211_conf David Kimdon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610162205.35649.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=dwhedon@devicescape.com \
--cc=jbenc@suse.cz \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=simon@devicescape.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.