From: David Kimdon <david.kimdon@devicescape.com>
To: Michael Buesch <mb@bu3sch.de>
Cc: David Kimdon <david.kimdon@devicescape.com>,
netdev@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Jiri Benc <jbenc@suse.cz>
Subject: Re: [patch 1/5] d80211: remove bitfields from ieee80211_tx_control
Date: Tue, 17 Oct 2006 10:19:51 -0700 [thread overview]
Message-ID: <20061017171951.GA13701@devicescape.com> (raw)
In-Reply-To: <200610161807.25261.mb@bu3sch.de>
On Mon, Oct 16, 2006 at 06:07:25PM +0200, Michael Buesch wrote:
> On Friday 13 October 2006 21:20, David Kimdon wrote:
> > All one-bit bitfields have been subsumed into the new 'flags'
> > structure member and the new IEEE80211_TXCTL_* definitions. The
> > multiple bit members were converted to u8, s8 or u16 as appropriate.
I'll answer based on take1, which I just sent to the list.
>
> And, eh, did this increase or decrease the struct size?
structure sizes did not change.
> Does this generate better or worse code?
It generates slightly smaller code with gcc 4.1.2.
-David
next prev parent reply other threads:[~2006-10-17 17:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061013191910.297963000@devicescape.com>
2006-10-13 19:20 ` [patch 1/5] d80211: remove bitfields from ieee80211_tx_control David Kimdon
2006-10-16 16:07 ` Michael Buesch
2006-10-16 19:34 ` Simon Barber
2006-10-16 20:05 ` Michael Buesch
2006-10-17 17:26 ` David Kimdon
2006-10-17 17:19 ` David Kimdon [this message]
2006-10-13 19:20 ` [patch 2/5] d80211: remove bitfields from ieee80211_tx_status David Kimdon
2006-10-13 19:21 ` [patch 3/5] d80211: remove bitfields from ieee80211_key_conf David Kimdon
2006-10-13 19:21 ` [patch 4/5] d80211: remove bitfields from ieee80211_hw David Kimdon
2006-10-13 19:21 ` [patch 5/5] d80211: remove bitfields from ieee80211_conf David Kimdon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061017171951.GA13701@devicescape.com \
--to=david.kimdon@devicescape.com \
--cc=jbenc@suse.cz \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.