From: Ingo Molnar <mingo@elte.hu>
To: Daniel Walker <dwalker@mvista.com>
Cc: linuxppc-dev@ozlabs.org, tglx@linutronix.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -rt] powerpc update
Date: Wed, 18 Oct 2006 09:28:58 +0200 [thread overview]
Message-ID: <20061018072858.GA29576@elte.hu> (raw)
In-Reply-To: <20061003155358.756788000@dwalker1.mvista.com>
* Daniel Walker <dwalker@mvista.com> wrote:
> Pay close attention to the fasteoi interrupt threading. I added usage
> of mask/unmask instead of using level handling, which worked well on
> PPC.
this is wrong - it should be doing mask+ack.
also note that you changed:
> - goto out_unlock;
to:
> + goto out;
and you even tried to hide your tracks:
> out:
> desc->chip->eoi(irq);
> -out_unlock:
> spin_unlock(&desc->lock);
:-)
really, the ->eoi() op should only be called for true fasteoi cases.
What we want here is to turn the fasteoi handler into a handler that
does mask+ack and then unmask. Not 'mask+eoi ... unmask' as your patch
does.
Ingo
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Daniel Walker <dwalker@mvista.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
tglx@linutronix.de, mgreer@mvista.com, sshtylyov@ru.mvista.com
Subject: Re: [PATCH -rt] powerpc update
Date: Wed, 18 Oct 2006 09:28:58 +0200 [thread overview]
Message-ID: <20061018072858.GA29576@elte.hu> (raw)
In-Reply-To: <20061003155358.756788000@dwalker1.mvista.com>
* Daniel Walker <dwalker@mvista.com> wrote:
> Pay close attention to the fasteoi interrupt threading. I added usage
> of mask/unmask instead of using level handling, which worked well on
> PPC.
this is wrong - it should be doing mask+ack.
also note that you changed:
> - goto out_unlock;
to:
> + goto out;
and you even tried to hide your tracks:
> out:
> desc->chip->eoi(irq);
> -out_unlock:
> spin_unlock(&desc->lock);
:-)
really, the ->eoi() op should only be called for true fasteoi cases.
What we want here is to turn the fasteoi handler into a handler that
does mask+ack and then unmask. Not 'mask+eoi ... unmask' as your patch
does.
Ingo
next prev parent reply other threads:[~2006-10-18 8:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-03 15:53 [PATCH -rt] powerpc update Daniel Walker
2006-10-03 15:53 ` Daniel Walker
2006-10-18 7:28 ` Ingo Molnar [this message]
2006-10-18 7:28 ` Ingo Molnar
2006-10-18 7:32 ` Ingo Molnar
2006-10-18 7:32 ` Ingo Molnar
2006-10-18 14:32 ` Daniel Walker
2006-10-18 14:32 ` Daniel Walker
2006-10-18 14:32 ` Ingo Molnar
2006-10-18 14:32 ` Ingo Molnar
2006-10-18 14:33 ` Ingo Molnar
2006-10-18 14:33 ` Ingo Molnar
2006-10-18 14:52 ` Daniel Walker
2006-10-18 14:52 ` Daniel Walker
2006-10-18 20:54 ` Daniel Walker
2006-10-18 20:54 ` Daniel Walker
2006-10-28 15:05 ` Sergei Shtylyov
2006-10-28 15:05 ` Sergei Shtylyov
2006-10-28 15:33 ` Sergei Shtylyov
2006-10-28 15:33 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061018072858.GA29576@elte.hu \
--to=mingo@elte.hu \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.