All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	Linus Torvalds <torvalds@osdl.org>, Jeff Garzik <jeff@garzik.org>
Subject: revert mv643xx change from ubuntu tree
Date: Thu, 19 Oct 2006 14:18:36 +0200	[thread overview]
Message-ID: <20061019121836.GA26319@aepfle.de> (raw)


Somehow the Ubuntu guys managed to sneak this compile error into the
tree:

commit ce9e3d9953c8cb67001719b5516da2928e956be4

      [mv643xx] Add pci device table for auto module loading.

drivers/net/mv643xx_eth.c:1560: error: array type has incomplete element type
drivers/net/mv643xx_eth.c:1561: warning: implicit declaration of function ‘PCI_DEVICE’
drivers/net/mv643xx_eth.c:1561: error: ‘PCI_VENDOR_ID_MARVELL’ undeclared here (not in a function)
drivers/net/mv643xx_eth.c:1561: error: ‘PCI_DEVICE_ID_MARVELL_MV64360’ undeclared here (not in a function)


This change is also wrong, the autoloading works perfect with 2.6.18,
no need to add random PCI ids.

http://ozlabs.org/pipermail/linuxppc-dev/2006-October/026544.html

Please revert this change and route changes via jgarzik etc...

             reply	other threads:[~2006-10-19 12:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-19 12:18 Olaf Hering [this message]
2006-10-20  4:35 ` revert mv643xx change from ubuntu tree Ben Collins
2006-10-20  5:38   ` Olaf Hering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061019121836.GA26319@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.