From: Olaf Hering <olaf@aepfle.de>
To: Ben Collins <ben.collins@ubuntu.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Linus Torvalds <torvalds@osdl.org>, Jeff Garzik <jeff@garzik.org>
Subject: Re: revert mv643xx change from ubuntu tree
Date: Fri, 20 Oct 2006 07:38:56 +0200 [thread overview]
Message-ID: <20061020053856.GA3277@aepfle.de> (raw)
In-Reply-To: <1161318901.31915.21.camel@gullible>
On Fri, Oct 20, Ben Collins wrote:
> On Thu, 2006-10-19 at 14:18 +0200, Olaf Hering wrote:
> > Somehow the Ubuntu guys managed to sneak this compile error into the
> > tree:
> >
> > commit ce9e3d9953c8cb67001719b5516da2928e956be4
> >
> > [mv643xx] Add pci device table for auto module loading.
> >
> > drivers/net/mv643xx_eth.c:1560: error: array type has incomplete element type
> > drivers/net/mv643xx_eth.c:1561: warning: implicit declaration of function ‘PCI_DEVICE’
> > drivers/net/mv643xx_eth.c:1561: error: ‘PCI_VENDOR_ID_MARVELL’ undeclared here (not in a function)
> > drivers/net/mv643xx_eth.c:1561: error: ‘PCI_DEVICE_ID_MARVELL_MV64360’ undeclared here (not in a function)
>
> Correct, I missed the include for linux/pci.h.
>
> This patch has been trailing our tree since 2.6.12. Could you help me to
> understand what in this driver will cause it to be autoloaded by udev
> when compiled as a module?
See commit ce9e3d9953c8cb67001719b5516da2928e956be4, platform devices
have now a modalias entry in sysfs. The network card is not a PCI
device.
prev parent reply other threads:[~2006-10-20 5:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-19 12:18 revert mv643xx change from ubuntu tree Olaf Hering
2006-10-20 4:35 ` Ben Collins
2006-10-20 5:38 ` Olaf Hering [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061020053856.GA3277@aepfle.de \
--to=olaf@aepfle.de \
--cc=ben.collins@ubuntu.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.