Re: [PATCH] don't use mlock() with Solaris tools

[Daniel Veillard <veillard@redhat.com>]

On Fri, Oct 20, 2006 at 04:42:47AM +0100, John Levon wrote:
> on solaris: mlock requires a page aligned address and mlock doesn't ensure the pages won't minor page fault; so don't use it on solaris.
[...]
> -/* NB: arr must be mlock'ed */
> +int lock_pages(void *addr, size_t len)
> +{
> +      int e = 0;
> +#ifndef __sun__
> +      e = mlock(addr, len);
> +#endif
> +      return (e);
> +}
> +
> +void unlock_pages(void *addr, size_t len)
> +{
> +#ifndef __sun__
> +	safe_munlock(addr, len);
> +#endif
> +}
> +

  So on Solaris you don't pin down the memory used for hypercall parameters
and results at all ? Is there really no risk associated with this strategy ?

  surprised,

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard@redhat.com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/