Re: [PATCH 6/6] xen,tools: add numa stat tool and hcalls

[Ryan Harper <ryanh@us.ibm.com>]

* John Levon <levon@movementarian.org> [2006-10-23 15:53]:
> On Mon, Oct 23, 2006 at 01:09:28PM -0500, Ryan Harper wrote:
> 
> > This patch adds a tool used to display how memory for each domain was
> > allocated (which nodes does a domain's memory reside within).  It also
> > dumps information about the Xen heap, including how many pages are in
> > each zone and node.
> 
> +        struct xen_domctl_availheap         availheap;
> +        struct xen_domctl_getdomnodestat    getdomnodestat;
>          uint8_t                             pad[128];
> 
> Don't you need to alter the pad to compensate?

AFAIK, I don't.  My understanding is that the pad[128] is the maximum
size for any member of the union.  Neither of the two added hypercalls
exceed 128.  

-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
(512) 838-9253   T/L: 678-9253
ryanh@us.ibm.com