[PATCH] Fix use of uninitialized variable in drivers/video/sis/init301.c::SiS_DDC2Delay()

[PATCH] Fix use of uninitialized variable in drivers/video/sis/init301.c::SiS_DDC2Delay()

[Jesper Juhl]

The variable 'j' is used uninitialized in the loop. Fix by initializing it to zero.

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---

 drivers/video/sis/init301.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/video/sis/init301.c b/drivers/video/sis/init301.c
index f13fadd..f65bedb 100644
--- a/drivers/video/sis/init301.c
+++ b/drivers/video/sis/init301.c
@@ -445,7 +445,8 @@ #endif
 void
 SiS_DDC2Delay(struct SiS_Private *SiS_Pr, unsigned int delaytime)
 {
-   unsigned int i, j;
+   unsigned int i
+   unsigned int j = 0;
 
    for(i = 0; i < delaytime; i++) {
       j += SiS_GetReg(SiS_Pr->SiS_P3c4,0x05);

Re: [PATCH] Fix use of uninitialized variable in drivers/video/sis/init301.c::SiS_DDC2Delay()

[David Rientjes]

On Mon, 23 Oct 2006, Jesper Juhl wrote:

> The variable 'j' is used uninitialized in the loop. Fix by initializing it to zero.
> 
> Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
> ---
> 
>  drivers/video/sis/init301.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/sis/init301.c b/drivers/video/sis/init301.c
> index f13fadd..f65bedb 100644
> --- a/drivers/video/sis/init301.c
> +++ b/drivers/video/sis/init301.c
> @@ -445,7 +445,8 @@ #endif
>  void
>  SiS_DDC2Delay(struct SiS_Private *SiS_Pr, unsigned int delaytime)
>  {
> -   unsigned int i, j;
> +   unsigned int i
> +   unsigned int j = 0;
>  
>     for(i = 0; i < delaytime; i++) {
>        j += SiS_GetReg(SiS_Pr->SiS_P3c4,0x05);
> 
> 

I doubt this patch compile tested.

		David

Re: [PATCH] Fix use of uninitialized variable in drivers/video/sis/init301.c::SiS_DDC2Delay()

[Jesper Juhl]

On Monday 23 October 2006 23:26, David Rientjes wrote:
> On Mon, 23 Oct 2006, Jesper Juhl wrote:
> 
> > The variable 'j' is used uninitialized in the loop. Fix by initializing it to zero.
> > 
[snip]
> 
> I doubt this patch compile tested.
> 
You are right. I hang my head in shame and admit I did not compile test this one.
Fixed patch below.


Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---

 drivers/video/sis/init301.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/video/sis/init301.c b/drivers/video/sis/init301.c
index f13fadd..45a5969 100644
--- a/drivers/video/sis/init301.c
+++ b/drivers/video/sis/init301.c
@@ -445,7 +445,8 @@ #endif
 void
 SiS_DDC2Delay(struct SiS_Private *SiS_Pr, unsigned int delaytime)
 {
-   unsigned int i, j;
+   unsigned int i;
+   unsigned int j = 0;
 
    for(i = 0; i < delaytime; i++) {
       j += SiS_GetReg(SiS_Pr->SiS_P3c4,0x05);

Re: [PATCH] Fix use of uninitialized variable in drivers/video/sis/init301.c::SiS_DDC2Delay()

[Jesper Juhl]

On 23/10/06, Jesper Juhl <jesper.juhl@gmail.com> wrote:
> On Monday 23 October 2006 23:26, David Rientjes wrote:
> > On Mon, 23 Oct 2006, Jesper Juhl wrote:
> >
> > > The variable 'j' is used uninitialized in the loop. Fix by initializing it to zero.
> > >
> [snip]
> >
> > I doubt this patch compile tested.
> >
> You are right. I hang my head in shame and admit I did not compile test this one.
> Fixed patch below.
>
>
> Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
> ---
>
>  drivers/video/sis/init301.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/sis/init301.c b/drivers/video/sis/init301.c
> index f13fadd..45a5969 100644
> --- a/drivers/video/sis/init301.c
> +++ b/drivers/video/sis/init301.c
> @@ -445,7 +445,8 @@ #endif
>  void
>  SiS_DDC2Delay(struct SiS_Private *SiS_Pr, unsigned int delaytime)
>  {
> -   unsigned int i, j;
> +   unsigned int i;
> +   unsigned int j = 0;
>
>     for(i = 0; i < delaytime; i++) {
>        j += SiS_GetReg(SiS_Pr->SiS_P3c4,0x05);
>
Damn it, my brain seems to be non-functional tonight.
'j' is not used at all. just ignore this patch. I'll come up with
something proper some other day - right now it's obviously time for me
to get some sleep.


-- 
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html