From: Christoph Hellwig <hch@infradead.org>
To: Nigel Cunningham <ncunningham@linuxmail.org>
Cc: Andrew Morton <akpm@osdl.org>, "Rafael J. Wysocki" <rjw@sisk.pl>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Use extents for recording what swap is allocated.
Date: Tue, 24 Oct 2006 21:42:39 +0100 [thread overview]
Message-ID: <20061024204239.GA15689@infradead.org> (raw)
In-Reply-To: <1161576857.3466.9.camel@nigel.suspend2.net>
On Mon, Oct 23, 2006 at 02:14:17PM +1000, Nigel Cunningham wrote:
> Switch from bitmaps to using extents to record what swap is allocated;
> they make more efficient use of memory, particularly where the allocated
> storage is small and the swap space is large.
>
> This is also part of the ground work for implementing support for
> supporting multiple swap devices.
In addition to the very useful comments from Rafael there's some observations
of my own:
- there's an awful lot of opencoded list manipulation, any chance you
could use list.h instead?
- what unit are the extent values in? The usage of unsigned long rings
warning bells for me, shouldn't this be something like pgoff_t or
sector_t depending on what you describe with it?
next prev parent reply other threads:[~2006-10-24 20:42 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-23 4:14 [PATCH] Use extents for recording what swap is allocated Nigel Cunningham
2006-10-23 15:32 ` Pavel Machek
2006-10-23 23:04 ` Nigel Cunningham
2006-10-24 8:43 ` Rafael J. Wysocki
2006-10-24 20:08 ` Rafael J. Wysocki
2006-10-24 21:34 ` Pavel Machek
2006-10-24 21:58 ` Rafael J. Wysocki
2006-10-24 22:15 ` Nigel Cunningham
2006-10-24 22:19 ` Pavel Machek
2006-10-24 22:30 ` Nigel Cunningham
2006-10-25 8:11 ` Pavel Machek
2006-10-25 8:28 ` Nigel Cunningham
2006-10-25 8:42 ` Pavel Machek
2006-10-25 9:01 ` Nigel Cunningham
2006-10-25 9:10 ` Pavel Machek
2006-10-25 10:05 ` Nigel Cunningham
2006-10-25 12:46 ` Rafael J. Wysocki
2006-10-27 11:37 ` Pavel Machek
2006-10-24 22:13 ` Nigel Cunningham
2006-10-24 22:45 ` Rafael J. Wysocki
2006-10-24 23:05 ` Nigel Cunningham
2006-10-31 11:39 ` Nigel Cunningham
2006-10-24 20:42 ` Christoph Hellwig [this message]
2006-10-24 20:58 ` Rafael J. Wysocki
2006-10-24 22:06 ` Nigel Cunningham
2006-10-24 22:47 ` Christoph Hellwig
2006-10-24 23:03 ` Nigel Cunningham
2006-10-25 9:17 ` Jens Axboe
2006-10-25 10:07 ` Nigel Cunningham
2006-10-25 10:20 ` Jens Axboe
2006-10-31 11:38 ` Nigel Cunningham
2006-11-01 12:36 ` Pavel Machek
2006-11-01 21:19 ` Nigel Cunningham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061024204239.GA15689@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ncunningham@linuxmail.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.