* [2.6 patch] ext4_ext_split(): remove dead code
@ 2006-11-06 10:05 Adrian Bunk
0 siblings, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2006-11-06 10:05 UTC (permalink / raw)
To: ext2-devel; +Cc: linux-kernel
The Coverity checker noted that this was dead code, since in all places
above in this function, "err" is immediately checked.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6/fs/ext4/extents.c.old 2006-11-06 11:02:09.000000000 +0100
+++ linux-2.6/fs/ext4/extents.c 2006-11-06 11:02:29.000000000 +0100
@@ -800,9 +800,6 @@ static int ext4_ext_split(handle_t *hand
}
/* insert new index */
- if (err)
- goto cleanup;
-
err = ext4_ext_insert_index(handle, inode, path + at,
le32_to_cpu(border), newblock);
^ permalink raw reply [flat|nested] 2+ messages in thread
* [2.6 patch] ext4_ext_split(): remove dead code
@ 2006-11-06 10:05 Adrian Bunk
0 siblings, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2006-11-06 10:05 UTC (permalink / raw)
To: ext2-devel; +Cc: linux-kernel
The Coverity checker noted that this was dead code, since in all places
above in this function, "err" is immediately checked.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6/fs/ext4/extents.c.old 2006-11-06 11:02:09.000000000 +0100
+++ linux-2.6/fs/ext4/extents.c 2006-11-06 11:02:29.000000000 +0100
@@ -800,9 +800,6 @@ static int ext4_ext_split(handle_t *hand
}
/* insert new index */
- if (err)
- goto cleanup;
-
err = ext4_ext_insert_index(handle, inode, path + at,
le32_to_cpu(border), newblock);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-11-06 10:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-06 10:05 [2.6 patch] ext4_ext_split(): remove dead code Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2006-11-06 10:05 Adrian Bunk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.