From: Arnd Bergmann <arnd@arndb.de>
To: Hoang-Nam Ngyuen <hnguyen@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, openib-general@openib.org,
linuxppc-dev@ozlabs.org, raisch@de.ibm.com
Subject: Re: [PATCH 2.6.19 1/4] ehca: assure 4k alignment for firmware control block in 64k page mode
Date: Mon, 6 Nov 2006 22:35:28 +0100 [thread overview]
Message-ID: <200611062235.28667.arnd@arndb.de> (raw)
In-Reply-To: <200611062226.44939.hnguyen@linux.vnet.ibm.com>
On Monday 06 November 2006 22:26, Hoang-Nam Ngyuen wrote:
> -=A0=A0=A0=A0=A0=A0=A0rblock =3D kzalloc(H_CB_ALIGNMENT, GFP_KERNEL);
> +=A0=A0=A0=A0=A0=A0=A0rblock =3D (struct hipz_query_hca*)ehca_alloc_fw_ct=
rlblock();
> =A0
> -=A0=A0=A0=A0=A0=A0=A0rblock =3D kzalloc(H_CB_ALIGNMENT, GFP_KERNEL);
> +=A0=A0=A0=A0=A0=A0=A0rblock =3D (struct hipz_query_port*)ehca_alloc_fw_c=
trlblock();
The point Heiko made in his comment is that with ehca_alloc_fw_ctrlblock
returning a void*, you can (and _should_) remove the casts to other
pointer types.
Arnd <><
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Hoang-Nam Ngyuen <hnguyen@linux.vnet.ibm.com>
Cc: rolandd@cisco.com, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, openib-general@openib.org,
hnguyen@de.ibm.com, raisch@de.ibm.com
Subject: Re: [PATCH 2.6.19 1/4] ehca: assure 4k alignment for firmware control block in 64k page mode
Date: Mon, 6 Nov 2006 22:35:28 +0100 [thread overview]
Message-ID: <200611062235.28667.arnd@arndb.de> (raw)
In-Reply-To: <200611062226.44939.hnguyen@linux.vnet.ibm.com>
On Monday 06 November 2006 22:26, Hoang-Nam Ngyuen wrote:
> - rblock = kzalloc(H_CB_ALIGNMENT, GFP_KERNEL);
> + rblock = (struct hipz_query_hca*)ehca_alloc_fw_ctrlblock();
>
> - rblock = kzalloc(H_CB_ALIGNMENT, GFP_KERNEL);
> + rblock = (struct hipz_query_port*)ehca_alloc_fw_ctrlblock();
The point Heiko made in his comment is that with ehca_alloc_fw_ctrlblock
returning a void*, you can (and _should_) remove the casts to other
pointer types.
Arnd <><
next prev parent reply other threads:[~2006-11-06 21:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-06 21:26 [PATCH 2.6.19 1/4] ehca: assure 4k alignment for firmware control block in 64k page mode Hoang-Nam Ngyuen
2006-11-06 21:26 ` Hoang-Nam Ngyuen
2006-11-06 21:35 ` Arnd Bergmann [this message]
2006-11-06 21:35 ` Arnd Bergmann
2006-11-06 23:56 ` Hoang-Nam Ngyuen
2006-11-06 23:56 ` Hoang-Nam Ngyuen
-- strict thread matches above, loose matches on Subject: below --
2006-11-05 20:40 Hoang-Nam Nguyen
2006-11-05 20:40 ` Hoang-Nam Nguyen
2006-11-05 23:45 ` Arnd Bergmann
2006-11-05 23:45 ` Arnd Bergmann
2006-11-06 10:00 ` Hoang-Nam Nguyen
2006-11-06 10:00 ` Hoang-Nam Nguyen
2006-11-06 10:39 ` Hoang-Nam Nguyen
2006-11-06 10:39 ` Hoang-Nam Nguyen
2006-11-06 16:51 ` Roland Dreier
2006-11-06 16:51 ` Roland Dreier
2006-11-06 17:45 ` Hoang-Nam Nguyen
2006-11-06 17:45 ` Hoang-Nam Nguyen
2006-11-06 16:50 ` Roland Dreier
2006-11-06 16:50 ` Roland Dreier
2006-11-06 14:58 ` Heiko Carstens
2006-11-06 14:58 ` Heiko Carstens
2006-11-06 16:13 ` Hoang-Nam Nguyen
2006-11-06 16:13 ` Hoang-Nam Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611062235.28667.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=hnguyen@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=openib-general@openib.org \
--cc=raisch@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.