All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gary Hade <garyhade@us.ibm.com>
To: cpufreq@lists.linux.org.uk, davej@redhat.com
Subject: [PATCH] speedstep-centrino should ignore upper performance control bits
Date: Mon, 6 Nov 2006 15:39:23 -0800	[thread overview]
Message-ID: <20061106233923.GA15063@us.ibm.com> (raw)


On some systems such as the IBM x3650 there are bits set in the 
upper half of the control values provided by the _PSS object.  
These bits are only relevant for cpufreq drivers that use IO ports 
which are not currently supported by the speedstep-centrino driver.  
The current MSR oriented code assumes that upper bits are not set 
and thus fails to work correctly when they are.  e.g. the control 
and status value equality check fails even though the ACPI spec 
allows the inequality.

Signed-off-by: Gary Hade <garyh@us.ibm.com>
---

--- linux-2.6.19-rc4/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c.orig	2006-11-06 10:40:03.000000000 -0800
+++ linux-2.6.19-rc4/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c	2006-11-06 14:23:23.849627864 -0800
@@ -463,6 +463,10 @@
 	}
 
 	for (i=0; i<p->state_count; i++) {
+		/* clear high bits (set by some BIOSes) that are non-relevant and 
+		   problematic for this driver's MSR only frequency transition code */
+		p->states[i].control &= 0xffff; 
+
 		if (p->states[i].control != p->states[i].status) {
 			dprintk("Different control (%llu) and status values (%llu)\n",
 				p->states[i].control, p->states[i].status);

             reply	other threads:[~2006-11-06 23:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-06 23:39 Gary Hade [this message]
2006-11-07  2:14 ` [PATCH] speedstep-centrino should ignore upper performance control bits Dominik Brodowski
2006-11-07  7:09   ` Len Brown
2006-11-07 18:49     ` Gary Hade
2006-11-08 23:21       ` Gary Hade
2006-11-08 23:29         ` Dave Jones
2006-11-09  0:00           ` Gary Hade
2006-11-09  0:22             ` Dave Jones
2006-11-10 19:20               ` Gary Hade
2006-11-07 18:57 ` Gary Hade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061106233923.GA15063@us.ibm.com \
    --to=garyhade@us.ibm.com \
    --cc=cpufreq@lists.linux.org.uk \
    --cc=davej@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.