* [PATCH] drm: fix return value check
@ 2006-11-08 12:46 Akinobu Mita
0 siblings, 0 replies; only message in thread
From: Akinobu Mita @ 2006-11-08 12:46 UTC (permalink / raw)
To: linux-kernel; +Cc: David Airlie
class_create() and class_device_create() return error code as a
pointer on failure. These return values need to be checked by
IS_ERR().
Cc: David Airlie <airlied@linux.ie>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
drivers/char/drm/drm_sysfs.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
Index: work-fault-inject/drivers/char/drm/drm_sysfs.c
===================================================================
--- work-fault-inject.orig/drivers/char/drm/drm_sysfs.c
+++ work-fault-inject/drivers/char/drm/drm_sysfs.c
@@ -45,8 +45,8 @@ struct class *drm_sysfs_create(struct mo
int err;
class = class_create(owner, name);
- if (!class) {
- err = -ENOMEM;
+ if (IS_ERR(class)) {
+ err = PTR_ERR(class);
goto err_out;
}
@@ -113,8 +113,8 @@ struct class_device *drm_sysfs_device_ad
MKDEV(DRM_MAJOR, head->minor),
&(head->dev->pdev)->dev,
"card%d", head->minor);
- if (!class_dev) {
- err = -ENOMEM;
+ if (IS_ERR(class_dev)) {
+ err = PTR_ERR(class_dev);
goto err_out;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-11-08 12:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-08 12:46 [PATCH] drm: fix return value check Akinobu Mita
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.