From: Jens Axboe <jens.axboe@oracle.com>
To: Brice Goglin <Brice.Goglin@ens-lyon.org>
Cc: Monty Montgomery <monty@xiph.org>, Tejun Heo <htejun@gmail.com>,
Gregor Jasny <gjasny@googlemail.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org, Douglas Gilbert <dougg@torque.net>
Subject: Re: 2.6.19-rc3 system freezes when ripping with cdparanoia at ioctl(SG_IO)
Date: Fri, 10 Nov 2006 17:23:30 +0100 [thread overview]
Message-ID: <20061110162330.GE15031@kernel.dk> (raw)
In-Reply-To: <4554A681.2000502@ens-lyon.org>
On Fri, Nov 10 2006, Brice Goglin wrote:
> Jens Axboe wrote:
> > On Thu, Nov 09 2006, Monty Montgomery wrote:
> >
> >> On 11/9/06, Tejun Heo <htejun@gmail.com> wrote:
> >>
> >>
> >>> drivers/scsi/sg.c interprets SG_DXFER_TO_FROM_DEV as read while
> >>> block/scsi_ioctl.c interprets it as write. I guess this is historic
> >>> thing (scsi/sg.c updated but block/scsi_ioctl.c is forgotten).
> >>>
> >> Not historic; Jens accidentally implemented it backwards. No one
> >> noticed for a long time. I submitted a patch for this a few months
> >> ago.
> >>
> >
> > Yeah, I wonder why that did not go in, I remember the full breadth of
> > our discussion and you are fully correct. I'll make sure it gets into
> > 2.6.19!
> >
>
> Note sure this patch was supposed to fix our freeze, but I just tried on
> top of rc5 and it does not seem to fix it.
It should fix Alex's issue with wrong data direction being seen, I
haven't had time to follow this thread today so cannot say.
--
Jens Axboe
next prev parent reply other threads:[~2006-11-10 16:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-29 19:20 2.6.19-rc3 system freezes when ripping with cdparanoia at ioctl(SG_IO) Gregor Jasny
2006-10-29 21:31 ` Ken Moffat
2006-10-29 22:05 ` Brice Goglin
2006-10-30 11:45 ` Jens Axboe
2006-10-30 13:14 ` Gregor Jasny
2006-10-30 13:17 ` Gregor Jasny
2006-10-30 13:27 ` Jens Axboe
2006-11-09 9:46 ` Brice Goglin
2006-11-09 14:00 ` Tejun Heo
2006-11-09 14:14 ` Jeff Garzik
2006-11-09 20:13 ` Monty Montgomery
2006-11-09 15:50 ` Douglas Gilbert
2006-11-10 10:36 ` Luben Tuikov
2006-11-10 12:58 ` Douglas Gilbert
2006-11-10 20:08 ` Luben Tuikov
2006-11-11 10:46 ` Christoph Hellwig
2006-11-11 16:39 ` Douglas Gilbert
2006-11-11 19:09 ` Luben Tuikov
2006-11-14 22:52 ` Monty Montgomery
2006-11-09 20:09 ` Monty Montgomery
2006-11-09 22:47 ` Tejun Heo
2006-11-10 16:15 ` Jens Axboe
2006-11-10 16:19 ` Brice Goglin
2006-11-10 16:23 ` Jens Axboe [this message]
2006-11-14 12:24 ` Brice Goglin
2006-11-14 12:29 ` Jens Axboe
2006-11-14 12:40 ` Brice Goglin
2006-11-14 12:50 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061110162330.GE15031@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=Brice.Goglin@ens-lyon.org \
--cc=dougg@torque.net \
--cc=gjasny@googlemail.com \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=monty@xiph.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.