From: Douglas Gilbert <dougg@torque.net>
To: Christoph Hellwig <hch@infradead.org>,
Luben Tuikov <ltuikov@yahoo.com>, Tejun Heo <htejun@gmail.com>,
Brice Goglin <Brice.Goglin@ens-lyon.org>,
Jens Axboe <jens.axboe@oracle.com>,
Gregor Jasny <gjasny@googlemail.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org, monty@xiph.org,
linux-scsi@vger.kernel.org
Subject: Re: 2.6.19-rc3 system freezes when ripping with cdparanoia at ioctl(SG_IO)
Date: Sat, 11 Nov 2006 11:39:44 -0500 [thread overview]
Message-ID: <4555FCD0.7030505@torque.net> (raw)
In-Reply-To: <20061111104642.GA3356@infradead.org>
Christoph Hellwig wrote:
> On Fri, Nov 10, 2006 at 12:08:15PM -0800, Luben Tuikov wrote:
>> P.S. I'd love to see SG_DXFER_TO_FROM_DEV completely ripped out
>> of sg.c, for obvious reasons. Can you not duplicate the resid "fix"
>> it provides into "FROM_DEV" -- do apps really rely on it?
>
> At the beginning of this thread it was mentioned cdparanio uses it.
> But in general we can't just rip out userland interfaces, we pretend
> to have a stable userspace abi (and except for the big sysfs mess that
> actually comes very close to the truth).
>
> What we should do is to document very well what SG_DXFER_TO_FROM_DEV
> is doing and that odd name that's been chosen for it. I'll prepare
> a patch for that.
Christoph,
It is documented and has been from day one. See scsi/sg.h
and http://sg.torque.net/sg/p/sg_v3_ho.html
Naming it is a challenge and at the time there
were no bidirectional transfers to/from a device
to worry about.
A more appropriate but impractical name might be:
SG_DXFER_TO_KERNEL_BUFFER_THEN_READ_FROM_DEV_VIA_KERNEL_BUFFER
Doug Gilbert
next prev parent reply other threads:[~2006-11-11 16:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-29 19:20 2.6.19-rc3 system freezes when ripping with cdparanoia at ioctl(SG_IO) Gregor Jasny
2006-10-29 21:31 ` Ken Moffat
2006-10-29 22:05 ` Brice Goglin
2006-10-30 11:45 ` Jens Axboe
2006-10-30 13:14 ` Gregor Jasny
2006-10-30 13:17 ` Gregor Jasny
2006-10-30 13:27 ` Jens Axboe
2006-11-09 9:46 ` Brice Goglin
2006-11-09 14:00 ` Tejun Heo
2006-11-09 14:14 ` Jeff Garzik
2006-11-09 20:13 ` Monty Montgomery
2006-11-09 15:50 ` Douglas Gilbert
2006-11-10 10:36 ` Luben Tuikov
2006-11-10 12:58 ` Douglas Gilbert
2006-11-10 20:08 ` Luben Tuikov
2006-11-11 10:46 ` Christoph Hellwig
2006-11-11 16:39 ` Douglas Gilbert [this message]
2006-11-11 19:09 ` Luben Tuikov
2006-11-14 22:52 ` Monty Montgomery
2006-11-09 20:09 ` Monty Montgomery
2006-11-09 22:47 ` Tejun Heo
2006-11-10 16:15 ` Jens Axboe
2006-11-10 16:19 ` Brice Goglin
2006-11-10 16:23 ` Jens Axboe
2006-11-14 12:24 ` Brice Goglin
2006-11-14 12:29 ` Jens Axboe
2006-11-14 12:40 ` Brice Goglin
2006-11-14 12:50 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4555FCD0.7030505@torque.net \
--to=dougg@torque.net \
--cc=Brice.Goglin@ens-lyon.org \
--cc=gjasny@googlemail.com \
--cc=hch@infradead.org \
--cc=htejun@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ltuikov@yahoo.com \
--cc=monty@xiph.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.