Re: [RFC][PATCH] ensure i_ino uniqueness in filesystems without permanent inode numbers (via idr)

[Al Viro <viro@ftp.linux.org.uk>]

On Tue, Nov 14, 2006 at 03:22:08PM -0500, Jeff Layton wrote:
> This patch is a first step at correcting these problems. It declares a
> new file_system_type flag (FS_I_INO_DYNAMIC). If this is set, then when
> new_inode is called, we'll use the IDR functions to generate a unique
> 31-bit value, leaving the first 100 inode numbers for statically
> allocated stuff like root inodes, etc. At inode deletion time, we
> idr_remove it so the i_ino value can be reused.

NAK.  All calls of new_inode() are triggered from within fs code;
there's no reason to introduce flags (which should be the last
resort) when you bloody well can have a separate helpers for that
case and have them called.  Explicitly.