From: David Brownell <david-b@pacbell.net>
To: Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>
Cc: Len Brown <lenb@kernel.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-acpi@vger.kernel.org
Subject: Re: 2.6.19-rc5 nasty ACPI regression, AE_TIME errors
Date: Thu, 16 Nov 2006 22:22:43 -0800 [thread overview]
Message-ID: <200611162222.44836.david-b@pacbell.net> (raw)
In-Reply-To: <455C8696.80508@linux.intel.com>
On Thursday 16 November 2006 7:41 am, Alexey Starikovskiy wrote:
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -467,8 +467,8 @@ static u32 acpi_ec_gpe_handler(void *dat
> status = acpi_os_execute(OSL_EC_BURST_HANDLER, acpi_ec_gpe_query, ec);
> }
> acpi_enable_gpe(NULL, ec->gpe_bit, ACPI_ISR);
> - return status == AE_OK ?
> - ACPI_INTERRUPT_HANDLED : ACPI_INTERRUPT_NOT_HANDLED;
> + WARN_ON(ACPI_FAILURE(status));
> + return ACPI_INTERRUPT_HANDLED;
> }
>
Strange ... applying this on top of the previous patch seems to work
much better, but that WARN_ON hasn't triggered. At least, not yet.
Updating to RC6, with your two patches installed...
- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: David Brownell <david-b@pacbell.net>
To: Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com>
Cc: Len Brown <lenb@kernel.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-acpi@vger.kernel.org
Subject: Re: 2.6.19-rc5 nasty ACPI regression, AE_TIME errors
Date: Thu, 16 Nov 2006 22:22:43 -0800 [thread overview]
Message-ID: <200611162222.44836.david-b@pacbell.net> (raw)
In-Reply-To: <455C8696.80508@linux.intel.com>
On Thursday 16 November 2006 7:41 am, Alexey Starikovskiy wrote:
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -467,8 +467,8 @@ static u32 acpi_ec_gpe_handler(void *dat
> status = acpi_os_execute(OSL_EC_BURST_HANDLER, acpi_ec_gpe_query, ec);
> }
> acpi_enable_gpe(NULL, ec->gpe_bit, ACPI_ISR);
> - return status == AE_OK ?
> - ACPI_INTERRUPT_HANDLED : ACPI_INTERRUPT_NOT_HANDLED;
> + WARN_ON(ACPI_FAILURE(status));
> + return ACPI_INTERRUPT_HANDLED;
> }
>
Strange ... applying this on top of the previous patch seems to work
much better, but that WARN_ON hasn't triggered. At least, not yet.
Updating to RC6, with your two patches installed...
- Dave
next prev parent reply other threads:[~2006-11-17 6:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-15 7:03 2.6.19-rc5 nasty ACPI regression, AE_TIME errors David Brownell
2006-11-15 7:48 ` Len Brown
2006-11-15 14:48 ` Alexey Starikovskiy
2006-11-15 21:56 ` David Brownell
2006-11-15 21:56 ` David Brownell
2006-11-16 1:10 ` David Brownell
2006-11-16 1:10 ` David Brownell
2006-11-16 15:41 ` Alexey Starikovskiy
2006-11-16 16:03 ` David Brownell
2006-11-16 16:23 ` Alexey Starikovskiy
2006-11-16 16:53 ` David Brownell
2006-11-16 21:56 ` Alexey Starikovskiy
2006-11-17 21:45 ` [Bulk] " David Brownell
2006-11-17 6:22 ` David Brownell [this message]
2006-11-17 6:22 ` David Brownell
2006-11-17 21:04 ` David Brownell
2006-11-18 16:18 ` Alexey Starikovskiy
2006-11-15 18:46 ` David Brownell
2006-11-21 14:47 ` Janosch Machowinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200611162222.44836.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=alexey.y.starikovskiy@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.