* [2.6 patch] drivers/pci/hotplug/ibmphp_pci.c: fix NULL dereference
@ 2006-11-17 1:19 Adrian Bunk
0 siblings, 0 replies; only message in thread
From: Adrian Bunk @ 2006-11-17 1:19 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, linux-pci
The correct order is: NULL check before dereference
Spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.19-rc5-mm2/drivers/pci/hotplug/ibmphp_pci.c.old 2006-11-16 22:44:42.000000000 +0100
+++ linux-2.6.19-rc5-mm2/drivers/pci/hotplug/ibmphp_pci.c 2006-11-16 22:43:44.000000000 +0100
@@ -1371,12 +1371,12 @@ static int unconfigure_boot_bridge (u8 b
}
bus = ibmphp_find_res_bus (sec_number);
- debug ("bus->busno is %x\n", bus->busno);
- debug ("sec_number is %x\n", sec_number);
if (!bus) {
err ("cannot find Bus structure for the bridged device\n");
return -EINVAL;
}
+ debug("bus->busno is %x\n", bus->busno);
+ debug("sec_number is %x\n", sec_number);
ibmphp_remove_bus (bus, busno);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-11-17 1:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-17 1:19 [2.6 patch] drivers/pci/hotplug/ibmphp_pci.c: fix NULL dereference Adrian Bunk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.