Re: 2.6.19-rc5-mm2 (Oops in class_device_remove_attrs during nodemgr_remove_host)

[Greg KH <greg@kroah.com>]

On Fri, Nov 17, 2006 at 04:24:27PM +0100, Stefan Richter wrote:
> I wrote:
> > Mattia Dongili wrote:
> >>>> http://oioio.altervista.org/linux/2.6.19-rc5-mm2-1-ko
> > and
> > http://oioio.altervista.org/linux/config-2.6.19-rc5-mm2-1
> > | # CONFIG_SYSFS_DEPRECATED is not set
> > 
> > | ieee1394: Node removed: ID:BUS[0-00:1023]  GUID[080046030227e7bb]
> > | ieee1394: Node removed: ID:BUS[20754571-38:0455]  GUID[00000000f8ee6067]
> > | BUG: unable to handle kernel NULL pointer dereference at virtual
> > address 000000a4
> > |  printing eip:
> > | c0238c60
> > | *pde = 00000000
> > | Oops: 0000 [#1]
> > | SMP
> > | last sysfs file: /devices/pci0000:00/0000:00:00.0/class
> > [...]
> > | EIP is at class_device_remove_attrs+0xd/0x34
> > | eax: f7e02b8c   ebx: 00000000   ecx: ffffffff   edx: 00000000
> > | esi: 00000000   edi: f7e02b8c   ebp: f7629e04   esp: f7629df8
> > | ds: 007b   es: 007b   ss: 0068
> > | Process rmmod (pid: 2419, ti=f7628000 task=f702a550 task.ti=f7628000)
> > | Stack: f7e02b8c f7e02b94 00000000 f7629e20 c0238d47 00000000 f7e02a30
> > f7e02b8c
> > |        f7e02a30 00000000 f7629e2c c0238d82 f7e029f4 f7629e54 f8d5da3d
> > f8d63087
> > |        013cb08b 00000026 000001c7 f8ee6067 00000000 00000000 f8d5da52
> > f7629e5c
> > | Call Trace:
> > |  [<c0238d47>] class_device_del+0xc0/0xf0
> > |  [<c0238d82>] class_device_unregister+0xb/0x15
> > |  [<f8d5da3d>] nodemgr_remove_ne+0x64/0x79 [ieee1394]
> > |  [<f8d5da5d>] __nodemgr_remove_host_dev+0xb/0xf [ieee1394]
> > |  [<c02366dc>] device_for_each_child+0x1d/0x46
> > |  [<f8d5dd82>] nodemgr_remove_host+0x36/0x5d [ieee1394]
> > |  [<f8d5b4f3>] __unregister_host+0x1b/0x9c [ieee1394]
> > |  [<f8d5b70b>] highlevel_remove_host+0x24/0x47 [ieee1394]
> > |  [<f8d5b14f>] hpsb_remove_host+0x3b/0x5c [ieee1394]
> > |  [<f8dcbf9d>] ohci1394_pci_remove+0x47/0x1c7 [ohci1394]
> > |  [<c01dd619>] pci_device_remove+0x19/0x39
> > 
> > Either the FireWire host's device->klist_children was overwritten before
> > the call to device_for_each_child
> 
> or *during* the run of device_for_each_child, which first successfully
> called nodemgr_remove_ne for node [0-00:1023] but then stumbled over the
> false node [20754571-38:0455].
> 
> > (perhaps nodemgr didn't hold a reference which it should have), or/and
> > all of this is an issue with the ongoing migration away from class_device.

I don't have any firewire class_device migration patches in -mm right
now.

I do have one sitting here if you wish to play around with it, but it
needs some more infrastructure patches that I have not really tested all
that well yet.

Either way, I don't think this is caused by any new class_device
patches, but I'm very willing to be proven wrong :)

thanks,

greg k-h