* [RFC: 2.6 patch] kernel/pid.c: remove two unused exports
@ 2006-11-21 19:41 Adrian Bunk
2006-11-21 20:33 ` Eric W. Biederman
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2006-11-21 19:41 UTC (permalink / raw)
To: Eric W. Biederman; +Cc: linux-kernel
This patch removes two unused exports.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.19-rc5-mm2/kernel/pid.c.old 2006-11-21 19:55:17.000000000 +0100
+++ linux-2.6.19-rc5-mm2/kernel/pid.c 2006-11-21 20:28:36.000000000 +0100
@@ -246,7 +246,6 @@
}
return NULL;
}
-EXPORT_SYMBOL_GPL(find_pid);
int fastcall attach_pid(struct task_struct *task, enum pid_type type, int nr)
{
@@ -359,7 +358,6 @@
return pid;
}
-EXPORT_SYMBOL_GPL(find_get_pid);
int copy_pid_ns(int flags, struct task_struct *tsk)
{
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFC: 2.6 patch] kernel/pid.c: remove two unused exports
2006-11-21 19:41 [RFC: 2.6 patch] kernel/pid.c: remove two unused exports Adrian Bunk
@ 2006-11-21 20:33 ` Eric W. Biederman
0 siblings, 0 replies; 2+ messages in thread
From: Eric W. Biederman @ 2006-11-21 20:33 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel
Adrian Bunk <bunk@stusta.de> writes:
> This patch removes two unused exports.
Ok. Could we hold off on this a little bit?
In general I think this is sane, but looking through my pending
patches I have at least one patch that uses find_get_pid from
a modular context.
The general issue is that drivers and thus most modules should
not be aware of pid_t values. However there do seem to be a few
rare exceptions.
Eric
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-11-21 20:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-21 19:41 [RFC: 2.6 patch] kernel/pid.c: remove two unused exports Adrian Bunk
2006-11-21 20:33 ` Eric W. Biederman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.