From: Matthew Wilcox <matthew@wil.cx>
To: Ingo Oeser <ioe-lkml@rameria.de>
Cc: Andrew Morton <akpm@osdl.org>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Grant Grundler <grundler@parisc-linux.org>,
linux-scsi@vger.kernel.org, e1000-devel@lists.sourceforge.net,
Greg KH <greg@kroah.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH 3/5] PCI : Add selected_regions funcs
Date: Thu, 23 Nov 2006 12:39:05 -0700 [thread overview]
Message-ID: <20061123193905.GD6083@parisc-linux.org> (raw)
In-Reply-To: <200611232033.35280.ioe-lkml@rameria.de>
On Thu, Nov 23, 2006 at 08:33:32PM +0100, Ingo Oeser wrote:
> bitfields (and bitmask) should be unsigned and use machine word size,
> which is usually "long". So please pass them in "unsigned long" instead of "int".
Why? We know how many BARs PCI devices have (6. Plus ROM. Plus 4
bridge resources, making 11). We could even use a u16. An int is fine,
there's no need to re-spin this patch.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <matthew@wil.cx>
To: Ingo Oeser <ioe-lkml@rameria.de>
Cc: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-pci@atrey.karlin.mff.cuni.cz, Greg KH <greg@kroah.com>,
Grant Grundler <grundler@parisc-linux.org>,
Andrew Morton <akpm@osdl.org>,
e1000-devel@lists.sourceforge.net, linux-scsi@vger.kernel.org,
Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Subject: Re: [PATCH 3/5] PCI : Add selected_regions funcs
Date: Thu, 23 Nov 2006 12:39:05 -0700 [thread overview]
Message-ID: <20061123193905.GD6083@parisc-linux.org> (raw)
In-Reply-To: <200611232033.35280.ioe-lkml@rameria.de>
On Thu, Nov 23, 2006 at 08:33:32PM +0100, Ingo Oeser wrote:
> bitfields (and bitmask) should be unsigned and use machine word size,
> which is usually "long". So please pass them in "unsigned long" instead of "int".
Why? We know how many BARs PCI devices have (6. Plus ROM. Plus 4
bridge resources, making 11). We could even use a u16. An int is fine,
there's no need to re-spin this patch.
next prev parent reply other threads:[~2006-11-23 19:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-22 8:06 [PATCH 3/5] PCI : Add selected_regions funcs Hidetoshi Seto
2006-11-22 8:06 ` Hidetoshi Seto
2006-11-23 19:33 ` Ingo Oeser
2006-11-23 19:33 ` Ingo Oeser
2006-11-23 19:39 ` Matthew Wilcox [this message]
2006-11-23 19:39 ` Matthew Wilcox
2006-11-23 21:42 ` Alan
2006-11-23 21:42 ` Alan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061123193905.GD6083@parisc-linux.org \
--to=matthew@wil.cx \
--cc=akpm@osdl.org \
--cc=e1000-devel@lists.sourceforge.net \
--cc=greg@kroah.com \
--cc=grundler@parisc-linux.org \
--cc=ioe-lkml@rameria.de \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linux-scsi@vger.kernel.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.