* [Cluster-devel] cluster/gfs-kernel/src/gfs lm.c
@ 2006-11-27 17:42 wcheng
0 siblings, 0 replies; 5+ messages in thread
From: wcheng @ 2006-11-27 17:42 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL5
Changes by: wcheng at sourceware.org 2006-11-27 17:42:07
Modified files:
gfs-kernel/src/gfs: lm.c
Log message:
bugzilla : 217374 - temporarily disable GFS1 withdraw until bz215962 is ready.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/lm.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.18&r2=1.18.2.1
--- cluster/gfs-kernel/src/gfs/lm.c 2006/09/20 18:48:56 1.18
+++ cluster/gfs-kernel/src/gfs/lm.c 2006/11/27 17:42:06 1.18.2.1
@@ -104,10 +104,18 @@
vprintk(fmt, args);
va_end(args);
+#if !defined(BZ_215962)
+ /*
+ * Temporarily disable GFS1 withdraw function until bz215962
+ * is ready.
+ */
+ printk("GFS: fsid=%s: about to withdraw from the cluster\n",
+ sdp->sd_fsname);
+ BUG();
+#else
printk("about to withdraw from the cluster\n");
BUG_ON(sdp->sd_args.ar_debug);
-
printk("waiting for outstanding I/O\n");
/* FIXME: suspend dm device so oustanding bio's complete
@@ -117,6 +125,7 @@
gfs2_withdraw_lockproto(&sdp->sd_lockstruct);
printk("withdrawn\n");
dump_stack();
+#endif
return -1;
}
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Cluster-devel] cluster/gfs-kernel/src/gfs lm.c
@ 2006-11-27 20:22 wcheng
0 siblings, 0 replies; 5+ messages in thread
From: wcheng @ 2006-11-27 20:22 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: wcheng at sourceware.org 2006-11-27 20:22:34
Modified files:
gfs-kernel/src/gfs: lm.c
Log message:
bugzilla : 217374 - temporarily disable GFS1 withdraw until bz215962 is ready.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/lm.c.diff?cvsroot=cluster&r1=1.18&r2=1.19
--- cluster/gfs-kernel/src/gfs/lm.c 2006/09/20 18:48:56 1.18
+++ cluster/gfs-kernel/src/gfs/lm.c 2006/11/27 20:22:34 1.19
@@ -104,10 +104,20 @@
vprintk(fmt, args);
va_end(args);
+#if !defined(BZ_215962)
+ /*
+ * Temporarily disable GFS1 withdraw function until bz215962
+ * is ready.
+ *
+ * A side note: BUG() does stack dump too.
+ */
+ printk("GFS: fsid=%s: about to withdraw from the cluster\n",
+ sdp->sd_fsname);
+ BUG();
+#else
printk("about to withdraw from the cluster\n");
BUG_ON(sdp->sd_args.ar_debug);
-
printk("waiting for outstanding I/O\n");
/* FIXME: suspend dm device so oustanding bio's complete
@@ -117,6 +127,7 @@
gfs2_withdraw_lockproto(&sdp->sd_lockstruct);
printk("withdrawn\n");
dump_stack();
+#endif
return -1;
}
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Cluster-devel] cluster/gfs-kernel/src/gfs lm.c
@ 2006-12-05 22:38 teigland
0 siblings, 0 replies; 5+ messages in thread
From: teigland @ 2006-12-05 22:38 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL50
Changes by: teigland at sourceware.org 2006-12-05 22:38:11
Modified files:
gfs-kernel/src/gfs: lm.c
Log message:
Call into the lock module to do a withdraw instead of just calling BUG.
bz 215962
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/lm.c.diff?cvsroot=cluster&only_with_tag=RHEL50&r1=1.18&r2=1.18.4.1
--- cluster/gfs-kernel/src/gfs/lm.c 2006/09/20 18:48:56 1.18
+++ cluster/gfs-kernel/src/gfs/lm.c 2006/12/05 22:38:11 1.18.4.1
@@ -104,18 +104,18 @@
vprintk(fmt, args);
va_end(args);
- printk("about to withdraw from the cluster\n");
- BUG_ON(sdp->sd_args.ar_debug);
-
+ printk("GFS: fsid=%s: about to withdraw from the cluster\n",
+ sdp->sd_fsname);
- printk("waiting for outstanding I/O\n");
+ BUG_ON(sdp->sd_args.ar_debug);
- /* FIXME: suspend dm device so oustanding bio's complete
- and all further io requests fail */
+ printk("GFS: fsid=%s: telling LM to withdraw\n",
+ sdp->sd_fsname);
- printk("telling LM to withdraw\n");
gfs2_withdraw_lockproto(&sdp->sd_lockstruct);
- printk("withdrawn\n");
+
+ printk("GFS: fsid=%s: withdrawn\n",
+ sdp->sd_fsname);
dump_stack();
return -1;
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Cluster-devel] cluster/gfs-kernel/src/gfs lm.c
@ 2006-12-05 22:38 teigland
0 siblings, 0 replies; 5+ messages in thread
From: teigland @ 2006-12-05 22:38 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Branch: RHEL5
Changes by: teigland at sourceware.org 2006-12-05 22:38:27
Modified files:
gfs-kernel/src/gfs: lm.c
Log message:
Call into the lock module to do a withdraw instead of just calling BUG.
bz 215962
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/lm.c.diff?cvsroot=cluster&only_with_tag=RHEL5&r1=1.18.2.1&r2=1.18.2.2
--- cluster/gfs-kernel/src/gfs/lm.c 2006/11/27 17:42:06 1.18.2.1
+++ cluster/gfs-kernel/src/gfs/lm.c 2006/12/05 22:38:26 1.18.2.2
@@ -104,28 +104,19 @@
vprintk(fmt, args);
va_end(args);
-#if !defined(BZ_215962)
- /*
- * Temporarily disable GFS1 withdraw function until bz215962
- * is ready.
- */
- printk("GFS: fsid=%s: about to withdraw from the cluster\n",
- sdp->sd_fsname);
- BUG();
-#else
- printk("about to withdraw from the cluster\n");
+ printk("GFS: fsid=%s: about to withdraw from the cluster\n",
+ sdp->sd_fsname);
+
BUG_ON(sdp->sd_args.ar_debug);
-
- printk("waiting for outstanding I/O\n");
- /* FIXME: suspend dm device so oustanding bio's complete
- and all further io requests fail */
+ printk("GFS: fsid=%s: telling LM to withdraw\n",
+ sdp->sd_fsname);
- printk("telling LM to withdraw\n");
gfs2_withdraw_lockproto(&sdp->sd_lockstruct);
- printk("withdrawn\n");
+
+ printk("GFS: fsid=%s: withdrawn\n",
+ sdp->sd_fsname);
dump_stack();
-#endif
return -1;
}
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Cluster-devel] cluster/gfs-kernel/src/gfs lm.c
@ 2006-12-05 22:38 teigland
0 siblings, 0 replies; 5+ messages in thread
From: teigland @ 2006-12-05 22:38 UTC (permalink / raw)
To: cluster-devel.redhat.com
CVSROOT: /cvs/cluster
Module name: cluster
Changes by: teigland at sourceware.org 2006-12-05 22:38:34
Modified files:
gfs-kernel/src/gfs: lm.c
Log message:
Call into the lock module to do a withdraw instead of just calling BUG.
bz 215962
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/cluster/gfs-kernel/src/gfs/lm.c.diff?cvsroot=cluster&r1=1.19&r2=1.20
--- cluster/gfs-kernel/src/gfs/lm.c 2006/11/27 20:22:34 1.19
+++ cluster/gfs-kernel/src/gfs/lm.c 2006/12/05 22:38:34 1.20
@@ -104,30 +104,19 @@
vprintk(fmt, args);
va_end(args);
-#if !defined(BZ_215962)
- /*
- * Temporarily disable GFS1 withdraw function until bz215962
- * is ready.
- *
- * A side note: BUG() does stack dump too.
- */
- printk("GFS: fsid=%s: about to withdraw from the cluster\n",
- sdp->sd_fsname);
- BUG();
-#else
- printk("about to withdraw from the cluster\n");
+ printk("GFS: fsid=%s: about to withdraw from the cluster\n",
+ sdp->sd_fsname);
+
BUG_ON(sdp->sd_args.ar_debug);
-
- printk("waiting for outstanding I/O\n");
- /* FIXME: suspend dm device so oustanding bio's complete
- and all further io requests fail */
+ printk("GFS: fsid=%s: telling LM to withdraw\n",
+ sdp->sd_fsname);
- printk("telling LM to withdraw\n");
gfs2_withdraw_lockproto(&sdp->sd_lockstruct);
- printk("withdrawn\n");
+
+ printk("GFS: fsid=%s: withdrawn\n",
+ sdp->sd_fsname);
dump_stack();
-#endif
return -1;
}
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-12-05 22:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-27 17:42 [Cluster-devel] cluster/gfs-kernel/src/gfs lm.c wcheng
-- strict thread matches above, loose matches on Subject: below --
2006-11-27 20:22 wcheng
2006-12-05 22:38 teigland
2006-12-05 22:38 teigland
2006-12-05 22:38 teigland
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.