All of lore.kernel.org
 help / color / mirror / Atom feed
From: Glauber de Oliveira Costa <gcosta@redhat.com>
To: Keir Fraser <keir@xensource.com>
Cc: Glauber de Oliveira Costa <glommer@gmail.com>,
	xen-devel@lists.xensource.com
Subject: Re: [PATCH] Avoid triggering the softlockup BUG when offline for too long.
Date: Wed, 29 Nov 2006 09:46:08 -0200	[thread overview]
Message-ID: <20061129114607.GA23434@redhat.com> (raw)
In-Reply-To: <C190E4E2.4E08%keir@xensource.com>

On Mon, Nov 27, 2006 at 06:54:26PM +0000, Keir Fraser wrote:
> > FYI, I just made a simple test checking for stolen time instead of
> > offline, and it's in fact called way too oftenly.
> 
> That doesn't make sense. Processed_stolen_time should lag at most 1 jiffy
> behind actual stolen time. So you still need to accumulate at least 10*HZ-1
> jiffies of stolen time in one go to end up touching the softlockup watchdog.
> As far as I can see, anyway. What workload did you run to test using stolen
> time?

Thanks for pointing it, Keir.

After going back to it, I found it to be a small mistake of mine. I was
calling the softlockup watchdog before accounting stolen ticks. Calling
it after it does the trick.

I'll resend the patch soon.

-- 
Glauber de Oliveira Costa
Red Hat Inc.
"Free as in Freedom"

  reply	other threads:[~2006-11-29 11:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-24 13:10 [PATCH] Avoid triggering the softlockup BUG when offline for too long Glauber de Oliveira Costa
2006-11-27 10:21 ` Keir Fraser
2006-11-27 15:31   ` Glauber de Oliveira Costa
2006-11-27 16:47     ` Glauber de Oliveira Costa
2006-11-27 18:54       ` Keir Fraser
2006-11-29 11:46         ` Glauber de Oliveira Costa [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-11-29 12:08 Glauber de Oliveira Costa
2006-11-29 12:18 ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061129114607.GA23434@redhat.com \
    --to=gcosta@redhat.com \
    --cc=glommer@gmail.com \
    --cc=keir@xensource.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.