All of lore.kernel.org
 help / color / mirror / Atom feed
From: Glauber de Oliveira Costa <gcosta@redhat.com>
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>, xen-devel@lists.xensource.com
Subject: [PATCH] Avoid triggering the softlockup BUG when offline for too long.
Date: Wed, 29 Nov 2006 10:08:59 -0200	[thread overview]
Message-ID: <20061129120859.GB23434@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 555 bytes --]

[LINUX] Avoid triggering the softlockup BUG when offline for too long.

After being offline for a long time, the softlockup  watchdog triggers
a BUG() on our faces. This is expected, as in fact, we spent more than
a fixed 10*HZ amount of time without touching the watchdog.

However, by inspecting the contents of stolen inside timer irq handler,
we can gain awareness of the fact, and do better than that.
This patch fixes it.

Signed-off-by: Glauber de Oliveira Costa <gcosta@redhat.com>

-- 
Glauber de Oliveira Costa
Red Hat Inc.
"Free as in Freedom"

[-- Attachment #2: xen-safepause.patch --]
[-- Type: text/plain, Size: 1186 bytes --]

# HG changeset patch
# User gcosta@redhat.com
# Date 1164805648 18000
# Node ID 24d24bca629bbd8f37319de34e12202814ccdde1
# Parent  47fcd5f768fef50cba2fc6dbadc7b75de55e88a5
[LINUX] Avoid triggering the softlockup BUG when offline for too long.

After being offline for a long time, the softlockup  watchdog triggers
a BUG() on our faces. This is expected, as in fact, we spent more than
a fixed 10*HZ amount of time without touching the watchdog.

However, by inspecting the contents of stolen inside timer irq handler,
we can gain awareness of the fact, and do better than that.
This patch fixes it.

Signed-off-by: Glauber de Oliveira Costa <gcosta@redhat.com>

diff -r 47fcd5f768fe -r 24d24bca629b linux-2.6-xen-sparse/arch/i386/kernel/time-xen.c
--- a/linux-2.6-xen-sparse/arch/i386/kernel/time-xen.c	Fri Nov 17 08:30:43 2006 -0500
+++ b/linux-2.6-xen-sparse/arch/i386/kernel/time-xen.c	Wed Nov 29 08:07:28 2006 -0500
@@ -710,6 +710,9 @@ irqreturn_t timer_interrupt(int irq, voi
 					    (cputime_t)delta_cpu);
 	}
 
+	if (stolen > 10*HZ) 
+		touch_softlockup_watchdog();
+	
 	/* Local timer processing (see update_process_times()). */
 	run_local_timers();
 	if (rcu_pending(cpu))

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

             reply	other threads:[~2006-11-29 12:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-29 12:08 Glauber de Oliveira Costa [this message]
2006-11-29 12:18 ` [PATCH] Avoid triggering the softlockup BUG when offline for too long Keir Fraser
  -- strict thread matches above, loose matches on Subject: below --
2006-11-24 13:10 Glauber de Oliveira Costa
2006-11-27 10:21 ` Keir Fraser
2006-11-27 15:31   ` Glauber de Oliveira Costa
2006-11-27 16:47     ` Glauber de Oliveira Costa
2006-11-27 18:54       ` Keir Fraser
2006-11-29 11:46         ` Glauber de Oliveira Costa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061129120859.GB23434@redhat.com \
    --to=gcosta@redhat.com \
    --cc=Keir.Fraser@cl.cam.ac.uk \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.