From: Gautham R Shenoy <ego@in.ibm.com>
To: Gautham R Shenoy <ego@in.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>,
mingo@elte.hu, linux-kernel@vger.kernel.org, torvalds@osdl.org,
davej@redhat.com, dipankar@in.ibm.com, vatsa@in.ibm.com
Subject: Re: CPUFREQ-CPUHOTPLUG: Possible circular locking dependency
Date: Thu, 30 Nov 2006 12:05:12 +0530 [thread overview]
Message-ID: <20061130063512.GA19492@in.ibm.com> (raw)
In-Reply-To: <20061130042807.GA4855@in.ibm.com>
On Thu, Nov 30, 2006 at 09:58:07AM +0530, Gautham R Shenoy wrote:
>
> So can we ignore this circular-dep warning as a false positive?
> Or is there a way to exploit this circular dependency ?
>
> At the moment, I cannot think of way to exploit this circular dependency
> unless we do something like try destroying the created workqueue when the
> cpu is dead, i.e make the cpufreq governors cpu-hotplug-aware.
> (eeks! that doesn't look good)
Ok, I see that we are already doing it :(. So we can end up in a
deadlock.
Here's the culprit callpath:
_cpu_down()
!
!-> raw_notifier_call_chain(CPU_LOCK_ACQUIRE)
! !
! !-> workqueue_cpu_mutex(CPU_LOCK_ACQUIRE) [*]
!
!-> raw_notifier_call_chain(CPU_DEAD)
!
!-> cpufreq_cpu_callback (CPU_DEAD)
!
!-> cpufreq_remove_dev
!
!-> __cpufreq_governor(data, GOVERNOR_STOP)
!
!-> policy->governor->governor()
!
!-> cpufreq_governor_dbs(GOVERNOR_STOP)
!
!-> destroy_workqueue() [*]
[*] indicates function takes workqueue_mutex.
So a deadlock!
I wasn't able to observe this because I'm running Xeon SMP box on which
you cannot offline cpu0. And cpufreq data is created only for cpu0,
while all other cpus cpufreq_data just point to cpu0's cpufreq_data.
So the mentioned callpath within cpufreq_remove_dev is never reached
during the normal cpu offline cycle.
However, if there are architectures which allow the first-booted-cpu
(or to be precise, the cpu for which cpufreq_data is *actually* created)
to be offlined and we are running Ondemand governor during the offline,
we will see this deadlock.
regards
gautham.
--
Gautham R Shenoy
Linux Technology Center
IBM India.
"Freedom comes with a price tag of responsibility, which is still a bargain,
because Freedom is priceless!"
next prev parent reply other threads:[~2006-11-30 6:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-29 15:24 CPUFREQ-CPUHOTPLUG: Possible circular locking dependency Gautham R Shenoy
2006-11-29 21:05 ` Andrew Morton
2006-11-30 4:28 ` Gautham R Shenoy
2006-11-30 6:35 ` Gautham R Shenoy [this message]
2006-11-30 8:29 ` Ingo Molnar
2006-11-30 8:52 ` Gautham R Shenoy
2006-12-01 1:43 ` Gautham R Shenoy
2006-12-01 8:55 ` Ingo Molnar
2006-11-30 8:31 ` Ingo Molnar
2006-11-30 10:24 ` Gautham R Shenoy
2006-11-30 11:03 ` Ingo Molnar
2006-11-30 11:19 ` Andrew Morton
2006-11-30 11:46 ` Ingo Molnar
2006-11-30 12:44 ` Gautham R Shenoy
2006-11-30 14:35 ` Ingo Molnar
2006-11-30 19:40 ` Andrew Morton
2006-11-30 20:24 ` Ingo Molnar
2006-11-30 11:43 ` Gautham R Shenoy
2006-11-30 11:53 ` Ingo Molnar
2006-11-30 12:19 ` Gautham R Shenoy
-- strict thread matches above, loose matches on Subject: below --
2006-12-06 18:27 Pallipadi, Venkatesh
2006-12-07 7:06 ` Gautham R Shenoy
2006-12-07 12:50 Pallipadi, Venkatesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061130063512.GA19492@in.ibm.com \
--to=ego@in.ibm.com \
--cc=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@osdl.org \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.