From: Gautham R Shenoy <ego@in.ibm.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@osdl.org>, Gautham R Shenoy <ego@in.ibm.com>,
linux-kernel@vger.kernel.org, torvalds@osdl.org,
davej@redhat.com, dipankar@in.ibm.com, vatsa@in.ibm.com
Subject: Re: CPUFREQ-CPUHOTPLUG: Possible circular locking dependency
Date: Thu, 30 Nov 2006 18:14:21 +0530 [thread overview]
Message-ID: <20061130124421.GB25439@in.ibm.com> (raw)
In-Reply-To: <20061130114617.GA2324@elte.hu>
On Thu, Nov 30, 2006 at 12:46:17PM +0100, Ingo Molnar wrote:
>
> struct task_struct {
> ...
> int hotplug_depth;
> struct mutex *hotplug_lock;
> }
> ...
>
> DEFINE_PER_CPU(struct mutex, hotplug_lock);
>
> void cpu_hotplug_lock(void)
> {
> int cpu = raw_smp_processor_id();
> /*
> * Interrupts/softirqs are hotplug-safe:
> */
> if (in_interrupt())
> return;
> if (current->hotplug_depth++)
> return;
> current->hotplug_lock = &per_cpu(hotplug_lock, cpu);
> mutex_lock(current->hotplug_lock);
> }
>
> void cpu_hotplug_unlock(void)
> {
> int cpu;
>
> if (in_interrupt())
> return;
> if (DEBUG_LOCKS_WARN_ON(!current->hotplug_depth))
> return;
> if (--current->hotplug_depth)
> return;
>
> mutex_unlock(current->hotplug_lock);
> current->hotplug_lock = NULL;
> }
>
In process context preemptible code,
Lets say we are currently running on processor i.
cpu_hotplug_lock() ; /* does mutex_lock(&percpu(hotplug_lock, i)) */
/* do some operation, which might sleep */
/* migrates to cpu j */
cpu_hotplug_unlock(); /* does mutex_unlock(&percpu(hotplug_lock, i)
while running on cpu j */
This would cause cacheline ping pong, no?
>
> Ingo
regards
gautham.
--
Gautham R Shenoy
Linux Technology Center
IBM India.
"Freedom comes with a price tag of responsibility, which is still a bargain,
because Freedom is priceless!"
next prev parent reply other threads:[~2006-11-30 12:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-29 15:24 CPUFREQ-CPUHOTPLUG: Possible circular locking dependency Gautham R Shenoy
2006-11-29 21:05 ` Andrew Morton
2006-11-30 4:28 ` Gautham R Shenoy
2006-11-30 6:35 ` Gautham R Shenoy
2006-11-30 8:29 ` Ingo Molnar
2006-11-30 8:52 ` Gautham R Shenoy
2006-12-01 1:43 ` Gautham R Shenoy
2006-12-01 8:55 ` Ingo Molnar
2006-11-30 8:31 ` Ingo Molnar
2006-11-30 10:24 ` Gautham R Shenoy
2006-11-30 11:03 ` Ingo Molnar
2006-11-30 11:19 ` Andrew Morton
2006-11-30 11:46 ` Ingo Molnar
2006-11-30 12:44 ` Gautham R Shenoy [this message]
2006-11-30 14:35 ` Ingo Molnar
2006-11-30 19:40 ` Andrew Morton
2006-11-30 20:24 ` Ingo Molnar
2006-11-30 11:43 ` Gautham R Shenoy
2006-11-30 11:53 ` Ingo Molnar
2006-11-30 12:19 ` Gautham R Shenoy
-- strict thread matches above, loose matches on Subject: below --
2006-12-06 18:27 Pallipadi, Venkatesh
2006-12-07 7:06 ` Gautham R Shenoy
2006-12-07 12:50 Pallipadi, Venkatesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061130124421.GB25439@in.ibm.com \
--to=ego@in.ibm.com \
--cc=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@osdl.org \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.