From: Al Viro <viro@ftp.linux.org.uk>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] Re: [GFS2] Change argument of gfs2_dinode_out [17/70]
Date: Fri, 1 Dec 2006 19:25:55 +0000 [thread overview]
Message-ID: <20061201192555.GD3078@ftp.linux.org.uk> (raw)
In-Reply-To: <1165000744.1194.89.camel@xenon.msp.redhat.com>
On Fri, Dec 01, 2006 at 01:19:04PM -0600, Russell Cattelan wrote:
> On Thu, 2006-11-30 at 12:15 +0000, Steven Whitehouse wrote:
> > >From 539e5d6b7ae8612c0393fe940d2da5b591318d3d Mon Sep 17 00:00:00 2001
> > From: Steven Whitehouse <swhiteho@redhat.com>
> > Date: Tue, 31 Oct 2006 15:07:05 -0500
> > Subject: [PATCH] [GFS2] Change argument of gfs2_dinode_out
> >
> > Everywhere this was called, a struct gfs2_inode was available,
> > but despite that, it was always called with a struct gfs2_dinode
> > as an argument. By making this change it paves the way to start
> > eliminating fields duplicated between the kernel's struct inode
> > and the struct gfs2_dinode.
> More pointless code churn.
>
> This only makes sense once the file system is working
> and we have time to do this type of cleanup on against
> a stable and TESTED code base.
Bzzert. Cleaner code is easier to _get_ stable. "Keep it ucking fugly
until everyone stops looking at it out of sheer disgust" is a bad idea.
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ftp.linux.org.uk>
To: Russell Cattelan <cattelan@thebarn.com>
Cc: Steven Whitehouse <swhiteho@redhat.com>,
cluster-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [GFS2] Change argument of gfs2_dinode_out [17/70]
Date: Fri, 1 Dec 2006 19:25:55 +0000 [thread overview]
Message-ID: <20061201192555.GD3078@ftp.linux.org.uk> (raw)
In-Reply-To: <1165000744.1194.89.camel@xenon.msp.redhat.com>
On Fri, Dec 01, 2006 at 01:19:04PM -0600, Russell Cattelan wrote:
> On Thu, 2006-11-30 at 12:15 +0000, Steven Whitehouse wrote:
> > >From 539e5d6b7ae8612c0393fe940d2da5b591318d3d Mon Sep 17 00:00:00 2001
> > From: Steven Whitehouse <swhiteho@redhat.com>
> > Date: Tue, 31 Oct 2006 15:07:05 -0500
> > Subject: [PATCH] [GFS2] Change argument of gfs2_dinode_out
> >
> > Everywhere this was called, a struct gfs2_inode was available,
> > but despite that, it was always called with a struct gfs2_dinode
> > as an argument. By making this change it paves the way to start
> > eliminating fields duplicated between the kernel's struct inode
> > and the struct gfs2_dinode.
> More pointless code churn.
>
> This only makes sense once the file system is working
> and we have time to do this type of cleanup on against
> a stable and TESTED code base.
Bzzert. Cleaner code is easier to _get_ stable. "Keep it ucking fugly
until everyone stops looking at it out of sheer disgust" is a bad idea.
next prev parent reply other threads:[~2006-12-01 19:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-30 12:15 [Cluster-devel] [GFS2] Change argument of gfs2_dinode_out [17/70] Steven Whitehouse
2006-11-30 12:15 ` Steven Whitehouse
2006-12-01 19:19 ` [Cluster-devel] " Russell Cattelan
2006-12-01 19:19 ` Russell Cattelan
2006-12-01 19:25 ` Al Viro [this message]
2006-12-01 19:25 ` Al Viro
2006-12-01 20:52 ` [Cluster-devel] " Russell Cattelan
2006-12-01 20:52 ` Russell Cattelan
2006-12-01 21:08 ` Al Viro
2006-12-01 21:08 ` Al Viro
2006-12-01 23:29 ` Russell Cattelan
2006-12-01 23:29 ` Russell Cattelan
2006-12-02 1:10 ` Al Viro
2006-12-02 1:10 ` Al Viro
2006-12-03 19:06 ` Russell Cattelan
2006-12-03 19:54 ` Christoph Hellwig
2006-12-03 22:44 ` Alan
2006-12-02 11:40 ` Pavel Machek
2006-12-02 11:40 ` Pavel Machek
2006-12-03 20:21 ` Rik van Riel
2006-12-03 20:21 ` Rik van Riel
2006-12-04 10:05 ` Steven Whitehouse
2006-12-04 10:05 ` Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061201192555.GD3078@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.