From: Arnd Bergmann <arnd@arndb.de>
To: cbe-oss-dev@ozlabs.org, maynardj@us.ibm.com
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
oprofile-list@lists.sourceforge.net
Subject: Re: [Cbe-oss-dev] [PATCH]Add notification for active Cell SPU tasks
Date: Sat, 2 Dec 2006 21:00:19 +0100 [thread overview]
Message-ID: <200612022100.20609.arnd@arndb.de> (raw)
In-Reply-To: <45708A0B.6000106@us.ibm.com>
On Friday 01 December 2006 21:01, Maynard Johnson wrote:
> +static void notify_spus_active(void)
> +{
> + int node;
> + for (node = 0; node < MAX_NUMNODES; node++) {
> + struct spu *spu;
> + mutex_lock(&spu_prio->active_mutex[node]);
> + list_for_each_entry(spu, &spu_prio->active_list[node], list) {
> + struct spu_context *ctx = spu->ctx;
> + blocking_notifier_call_chain(&spu_switch_notifier,
> + ctx ? ctx->object_id : 0, spu);
> + }
> + mutex_unlock(&spu_prio->active_mutex[node]);
> + }
I wonder if this is enough for oprofile. Don't you need to access user
space data of the task running on the SPU? I always assumed you want
to do it via get_user or copy_from_user, which obviously doesn't work
here, when you're running in the oprofile task. Are you using something
like access_process_vm now?
Arnd <><
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: cbe-oss-dev@ozlabs.org, maynardj@us.ibm.com
Cc: linuxppc-dev@ozlabs.org, oprofile-list@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [Cbe-oss-dev] [PATCH]Add notification for active Cell SPU tasks
Date: Sat, 2 Dec 2006 21:00:19 +0100 [thread overview]
Message-ID: <200612022100.20609.arnd@arndb.de> (raw)
In-Reply-To: <45708A0B.6000106@us.ibm.com>
On Friday 01 December 2006 21:01, Maynard Johnson wrote:
> +static void notify_spus_active(void)
> +{
> + int node;
> + for (node = 0; node < MAX_NUMNODES; node++) {
> + struct spu *spu;
> + mutex_lock(&spu_prio->active_mutex[node]);
> + list_for_each_entry(spu, &spu_prio->active_list[node], list) {
> + struct spu_context *ctx = spu->ctx;
> + blocking_notifier_call_chain(&spu_switch_notifier,
> + ctx ? ctx->object_id : 0, spu);
> + }
> + mutex_unlock(&spu_prio->active_mutex[node]);
> + }
I wonder if this is enough for oprofile. Don't you need to access user
space data of the task running on the SPU? I always assumed you want
to do it via get_user or copy_from_user, which obviously doesn't work
here, when you're running in the oprofile task. Are you using something
like access_process_vm now?
Arnd <><
next prev parent reply other threads:[~2006-12-02 20:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-01 20:01 [PATCH]Add notification for active Cell SPU tasks Maynard Johnson
2006-12-02 20:00 ` Arnd Bergmann [this message]
2006-12-02 20:00 ` [Cbe-oss-dev] " Arnd Bergmann
2006-12-04 15:36 ` Maynard Johnson
2006-12-04 15:36 ` Maynard Johnson
2006-12-04 12:26 ` Luke Browning
2006-12-06 19:30 ` Luke Browning
2006-12-06 22:04 ` Maynard Johnson
2006-12-06 22:04 ` Maynard Johnson
2006-12-07 22:58 ` [Cbe-oss-dev] " Arnd Bergmann
2006-12-07 22:58 ` Arnd Bergmann
2006-12-08 15:04 ` Maynard Johnson
2006-12-08 15:04 ` Maynard Johnson
2006-12-08 19:11 ` Luke Browning
2006-12-12 14:47 ` Maynard Johnson
2006-12-12 14:47 ` Maynard Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200612022100.20609.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=cbe-oss-dev@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=maynardj@us.ibm.com \
--cc=oprofile-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.