From: Ingo Molnar <mingo@elte.hu>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
dwalker@mvista.com
Subject: Re: [PATCH] 2.6.18-rt7: fix more issues with 32-bit cycles_t in latency_trace.c (take 3)
Date: Mon, 4 Dec 2006 17:23:00 +0100 [thread overview]
Message-ID: <20061204162300.GA23800@elte.hu> (raw)
In-Reply-To: <45744AF5.2040508@ru.mvista.com>
* Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote:
> > /* check for buggy clocks, handling wrap for 32-bit clocks */
> >- if (TYPE_EQUAL(cycles_t, unsigned long)) {
> >+ if (TYPE_EQUAL(cycle_t, unsigned long)) {
> > if (time_after((unsigned long)T1, (unsigned long)T2))
> > printk("bug: %08lx < %08lx!\n",
> > (unsigned long)T2, (unsigned long)T1);
>
> This earlier fix by Kevin woulnd't have sense anymore with cycle_t...
yeah, indeed - i've zapped this one too.
basically, what i'd like is the 32-bit clocks/cycles be handled
intelligently, and not adding to the cruft that already is in
kernel/latency_tracing.c.
Ingo
next prev parent reply other threads:[~2006-12-04 16:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-13 19:52 [PATCH] 2.6.18-rt7: fix more issues with 32-bit cycles_t in latency_trace.c (take 3) Sergei Shtylyov
2006-11-13 19:52 ` Sergei Shtylyov
2006-12-03 19:33 ` Sergei Shtylyov
2006-12-04 9:51 ` Ingo Molnar
2006-12-04 12:29 ` Sergei Shtylyov
2006-12-04 15:39 ` Ingo Molnar
2006-12-04 16:21 ` Sergei Shtylyov
2006-12-04 16:23 ` Ingo Molnar [this message]
2006-12-04 17:09 ` Sergei Shtylyov
2006-12-04 17:09 ` Sergei Shtylyov
2006-12-04 21:56 ` Roman Zippel
2006-12-04 21:56 ` Roman Zippel
2006-12-04 21:58 ` Ingo Molnar
2006-12-04 21:58 ` Ingo Molnar
2006-12-04 18:04 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061204162300.GA23800@elte.hu \
--to=mingo@elte.hu \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.