From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
dwalker@mvista.com
Subject: Re: [PATCH] 2.6.18-rt7: fix more issues with 32-bit cycles_t in latency_trace.c (take 3)
Date: Mon, 04 Dec 2006 15:29:15 +0300 [thread overview]
Message-ID: <4574149B.5070602@ru.mvista.com> (raw)
In-Reply-To: <20061204095131.GE7872@elte.hu>
Hello.
Ingo Molnar wrote:
>> What was the destiny of that patch? I haven't seen it accepted,
>>haven't seen any comments... while this is not a mere warning fix.
>>What am I expected to do to get it accepted -- recast it against
>>2.6.19-rt1?
> i'd suggest to redo it - but please keep it simple and clean. Those
> dozens of casts to u64 are quite ugly.
Alas, there's *nothing* I can do about it with 32-bit cycles_t. And if you
look at the kernel, this is not the only case of such "ugliness", look at this
commit for example:
http://www.kernel.org/git/?p=linux/kernel/git/paulus/powerpc.git;a=commit;h=685143ac1f7a579a3fac9c7f2ac8f82e95af6864
> Why is cycles_t 32-bits on some
> of the arches to begin with?
I guess this was done for speed reasons. That's not a qustion for me
although...
> Ingo
WBR, Sergei
next prev parent reply other threads:[~2006-12-04 12:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-13 19:52 [PATCH] 2.6.18-rt7: fix more issues with 32-bit cycles_t in latency_trace.c (take 3) Sergei Shtylyov
2006-11-13 19:52 ` Sergei Shtylyov
2006-12-03 19:33 ` Sergei Shtylyov
2006-12-04 9:51 ` Ingo Molnar
2006-12-04 12:29 ` Sergei Shtylyov [this message]
2006-12-04 15:39 ` Ingo Molnar
2006-12-04 16:21 ` Sergei Shtylyov
2006-12-04 16:23 ` Ingo Molnar
2006-12-04 17:09 ` Sergei Shtylyov
2006-12-04 17:09 ` Sergei Shtylyov
2006-12-04 21:56 ` Roman Zippel
2006-12-04 21:56 ` Roman Zippel
2006-12-04 21:58 ` Ingo Molnar
2006-12-04 21:58 ` Ingo Molnar
2006-12-04 18:04 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4574149B.5070602@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.