* [PATCH] Remove useless wmb() memory barrier
@ 2006-12-08 0:52 Ralf Baechle
0 siblings, 0 replies; only message in thread
From: Ralf Baechle @ 2006-12-08 0:52 UTC (permalink / raw)
To: linux-kernel
wake_up's implementation does an implicit memory barrier and I think
that's the only sane semantics as the caller shouldn't have to worry.
So this write memory barrier is useless.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
diff --git a/fs/xfs/linux-2.6/xfs_super.c b/fs/xfs/linux-2.6/xfs_super.c
index b93265b..33800c7 100644
--- a/fs/xfs/linux-2.6/xfs_super.c
+++ b/fs/xfs/linux-2.6/xfs_super.c
@@ -553,7 +553,6 @@ vfs_sync_worker(
error = bhv_vfs_sync(vfsp, SYNC_FSDATA | SYNC_BDFLUSH | \
SYNC_ATTR | SYNC_REFCACHE, NULL);
vfsp->vfs_sync_seq++;
- wmb();
wake_up(&vfsp->vfs_wait_single_sync_task);
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2006-12-08 0:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-08 0:52 [PATCH] Remove useless wmb() memory barrier Ralf Baechle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.