[patch] Add more xc_error_code values.

[patch] Add more xc_error_code values.

[Gerd Hoffmann]

[-- Attachment #1: tools-add-errors.diff --]
[-- Type: text/plain, Size: 686 bytes --]

XC_INVALID_PARAM
  such as asking for features unsupported by either xen or guest kernel.
XC_OUT_OF_MEMORY
  no comment ;)

Signed-off-by: Gerd Hoffmann <kraxel@suse.de>
---
 tools/libxc/xenctrl.h |    2 ++
 1 file changed, 2 insertions(+)

Index: build-32-unstable-12802/tools/libxc/xenctrl.h
===================================================================
--- build-32-unstable-12802.orig/tools/libxc/xenctrl.h
+++ build-32-unstable-12802/tools/libxc/xenctrl.h
@@ -687,6 +687,8 @@ typedef enum {
   XC_ERROR_NONE = 0,
   XC_INTERNAL_ERROR = 1,
   XC_INVALID_KERNEL = 2,
+  XC_INVALID_PARAM = 3,
+  XC_OUT_OF_MEMORY = 4,
 } xc_error_code;
 
 #define XC_MAX_ERROR_MSG_LEN 1024

-- 

Re: [patch] Add more xc_error_code values.

[Daniel P. Berrange]

On Fri, Dec 08, 2006 at 04:09:58PM +0100, Gerd Hoffmann wrote:
> XC_INVALID_PARAM
>   such as asking for features unsupported by either xen or guest kernel.
> XC_OUT_OF_MEMORY
>   no comment ;)
> 
> Signed-off-by: Gerd Hoffmann <kraxel@suse.de>
> ---
>  tools/libxc/xenctrl.h |    2 ++
>  1 file changed, 2 insertions(+)
> 
> Index: build-32-unstable-12802/tools/libxc/xenctrl.h
> ===================================================================
> --- build-32-unstable-12802.orig/tools/libxc/xenctrl.h
> +++ build-32-unstable-12802/tools/libxc/xenctrl.h
> @@ -687,6 +687,8 @@ typedef enum {
>    XC_ERROR_NONE = 0,
>    XC_INTERNAL_ERROR = 1,
>    XC_INVALID_KERNEL = 2,
> +  XC_INVALID_PARAM = 3,
> +  XC_OUT_OF_MEMORY = 4,
>  } xc_error_code;

You'll also want to add matching user friendly descriptions to the method
xc_error_code_to_description in tools/libxc/xc_private.c otherwise they'll
just get converted into 'Unknown error code'.  I thought I had a comment
to this effect just before the declaration of xc_error_code enum, but looks
like I mislaid it.

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

[patch] Add more xc_error_code values.

[Gerd Hoffmann]

[-- Attachment #1: tools-add-errors.diff --]
[-- Type: text/plain, Size: 1328 bytes --]

XC_INVALID_PARAM
  such as asking for features unsupported by either xen or guest kernel.
XC_OUT_OF_MEMORY
  no comment ;)

With description texts this time.

Signed-off-by: Gerd Hoffmann <kraxel@suse.de>
---
 tools/libxc/xc_private.c |    4 ++++
 tools/libxc/xenctrl.h    |    2 ++
 2 files changed, 6 insertions(+)

Index: build-32-unstable-12809/tools/libxc/xenctrl.h
===================================================================
--- build-32-unstable-12809.orig/tools/libxc/xenctrl.h
+++ build-32-unstable-12809/tools/libxc/xenctrl.h
@@ -691,6 +691,8 @@ typedef enum {
   XC_ERROR_NONE = 0,
   XC_INTERNAL_ERROR = 1,
   XC_INVALID_KERNEL = 2,
+  XC_INVALID_PARAM = 3,
+  XC_OUT_OF_MEMORY = 4,
 } xc_error_code;
 
 #define XC_MAX_ERROR_MSG_LEN 1024
Index: build-32-unstable-12809/tools/libxc/xc_private.c
===================================================================
--- build-32-unstable-12809.orig/tools/libxc/xc_private.c
+++ build-32-unstable-12809/tools/libxc/xc_private.c
@@ -45,6 +45,10 @@ const char *xc_error_code_to_desc(int co
         return "Internal error";
     case XC_INVALID_KERNEL:
         return "Invalid kernel";
+    case XC_INVALID_PARAM:
+        return "Invalid configuration";
+    case XC_OUT_OF_MEMORY:
+        return "Out of memory";
     }
 
     return "Unknown error code";

--