* [PATCH 1/1][DCCP] ccid3: return value in ccid3_hc_rx_calc_first_li
@ 2006-12-12 22:47 Arnaldo Carvalho de Melo
0 siblings, 0 replies; only message in thread
From: Arnaldo Carvalho de Melo @ 2006-12-12 22:47 UTC (permalink / raw)
To: dccp
David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.git
Thanks a lot,
- Arnaldo
-------------------------------- 8< -------------------------------
In a recent patch we introduced invalid return codes which will result in the
opposite of what is intended (i.e. send more packets in face of peculiar
network conditions).
This fixes it by returning ~0 which means not calculated as per
dccp_li_hist_calc_i_mean.
Signed-off-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
---
net/dccp/ccids/ccid3.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c
index fa6b753..40402c5 100644
--- a/net/dccp/ccids/ccid3.c
+++ b/net/dccp/ccids/ccid3.c
@@ -845,8 +845,8 @@ found:
* Find some p such that f(p) = fval; return 1/p [RFC 3448, 6.3.1].
*/
if (rtt = 0) { /* would result in divide-by-zero */
- DCCP_WARN("RTT=0, returning 1/p = 1\n");
- return 1000000;
+ DCCP_WARN("RTT=0\n");
+ return ~0;
}
dccp_timestamp(sk, &tstamp);
@@ -858,7 +858,7 @@ found:
DCCP_WARN("X_recv=0\n");
if ((x_recv = hcrx->ccid3hcrx_x_recv) = 0) {
DCCP_BUG("stored value of X_recv is zero");
- return 1000000;
+ return ~0;
}
}
--
1.4.2.1.g3d5c
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2006-12-12 22:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-12 22:47 [PATCH 1/1][DCCP] ccid3: return value in ccid3_hc_rx_calc_first_li Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.