From: Alan <alan@lxorguk.ukuu.org.uk>
To: mike.miller@hp.com
Cc: mikem@beardog.cca.cpqcorp.net, akpm@osdl.org,
jens.axboe@oracle.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/2] cciss: remove calls to pci_disable_device
Date: Tue, 12 Dec 2006 23:12:37 +0000 [thread overview]
Message-ID: <20061212231237.59581b28@localhost.localdomain> (raw)
In-Reply-To: <20061212195458.GB2471@beardog.cca.cpqcorp.net>
On Tue, 12 Dec 2006 13:54:58 -0600
"Mike Miller (OS Dev)" <mikem@beardog.cca.cpqcorp.net> wrote:
> PATCH 2/2
>
> This patch removes calls to pci_disable_device except in fail_all_cmds. The pci_disable_device function does something nasty to Smart Array controllers that pci_enable_device does not undo. So if the driver is unloaded it cannot be reloaded.
Acked-by: Alan Cox <alan@redhat.com>
Various devices do this. Please however update the patch or add a patch
which includes comments as to why or someone will helpfully put them back
one day.
WARNING: multiple messages have this Message-ID (diff)
From: Alan <alan@lxorguk.ukuu.org.uk>
To: mike.miller@hp.com, mikem@beardog.cca.cpqcorp.net
Cc: mikem@beardog.cca.cpqcorp.net, akpm@osdl.org,
jens.axboe@oracle.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 2/2] cciss: remove calls to pci_disable_device
Date: Tue, 12 Dec 2006 23:12:37 +0000 [thread overview]
Message-ID: <20061212231237.59581b28@localhost.localdomain> (raw)
In-Reply-To: <20061212195458.GB2471@beardog.cca.cpqcorp.net>
On Tue, 12 Dec 2006 13:54:58 -0600
"Mike Miller (OS Dev)" <mikem@beardog.cca.cpqcorp.net> wrote:
> PATCH 2/2
>
> This patch removes calls to pci_disable_device except in fail_all_cmds. The pci_disable_device function does something nasty to Smart Array controllers that pci_enable_device does not undo. So if the driver is unloaded it cannot be reloaded.
Acked-by: Alan Cox <alan@redhat.com>
Various devices do this. Please however update the patch or add a patch
which includes comments as to why or someone will helpfully put them back
one day.
next prev parent reply other threads:[~2006-12-12 23:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-12 19:54 [PATCH 2/2] cciss: remove calls to pci_disable_device Mike Miller (OS Dev)
2006-12-12 23:12 ` Alan [this message]
2006-12-12 23:12 ` Alan
2006-12-13 12:07 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061212231237.59581b28@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mike.miller@hp.com \
--cc=mikem@beardog.cca.cpqcorp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.