From: Dave Jones <davej@redhat.com>
To: Daniel Drake <dsd@gentoo.org>
Cc: davej@codemonkey.org.uk, linux list <linux-kernel@vger.kernel.org>
Subject: Re: amd64 agpgart aperture base value
Date: Thu, 14 Dec 2006 08:22:24 -0500 [thread overview]
Message-ID: <20061214132224.GD17565@redhat.com> (raw)
In-Reply-To: <4580C954.103@gentoo.org>
On Wed, Dec 13, 2006 at 10:47:32PM -0500, Daniel Drake wrote:
> In amd64-agp.c, would it be dangerous to remove the "aperture base > 4G"
> thing and instead simply only read the rightmost 7 bits to ensure the
> aperture base is always in range? (This is coming from someone with
> little AGPGART understanding...)
Ignoring the high bits is the wrong thing to be doing.
The BIOS placed the aperture in one place, and by masking bits, you're going
to be assuming its somewhere else, and scribbling over who knows what.
> Alternatively do you have other suggestions for how the problem might be
> solved better?
If the aperture is placed above 4G, we should deal with it. Currently, we
don't. (See the AGP patches Linus merged just before 2.6.19 was released
that work around this for intel-agp).
Just needs someone to find the time to write the code to do it, and test it.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2006-12-14 13:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-14 3:47 amd64 agpgart aperture base value Daniel Drake
2006-12-14 13:22 ` Dave Jones [this message]
2006-12-14 23:35 ` Daniel Drake
2006-12-15 0:02 ` Dave Jones
2006-12-18 11:38 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061214132224.GD17565@redhat.com \
--to=davej@redhat.com \
--cc=davej@codemonkey.org.uk \
--cc=dsd@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.