Re: amd64 agpgart aperture base value

[Daniel Drake <dsd@gentoo.org>]

Dave Jones wrote:
> On Wed, Dec 13, 2006 at 10:47:32PM -0500, Daniel Drake wrote:
> 
>  > In amd64-agp.c, would it be dangerous to remove the "aperture base > 4G" 
>  > thing and instead simply only read the rightmost 7 bits to ensure the 
>  > aperture base is always in range? (This is coming from someone with 
>  > little AGPGART understanding...)
> 
> Ignoring the high bits is the wrong thing to be doing.
> The BIOS placed the aperture in one place, and by masking bits, you're going
> to be assuming its somewhere else, and scribbling over who knows what.

So, you think that the aperture moving to a different location on every 
boot is what the BIOS desires? Is it normal for it to move so much?

The current patch drops the upper bits and results in the aperture 
always being in the same place, and this appears to work. If the BIOS 
did really put the aperture beyond 4GB but my patch is making Linux put 
it somewhere else, does it surprise you that things are still working 
smoothly?

Is it even possible for the aperture to start beyond 4GB when the system 
has less than 4GB of RAM?

> If the aperture is placed above 4G, we should deal with it. Currently, we
> don't. (See the AGP patches Linus merged just before 2.6.19 was released
> that work around this for intel-agp).
> 
> Just needs someone to find the time to write the code to do it, and test it.

Looks like some understanding of AGP is required too. I'll have a closer 
look another time.

Thanks,
Daniel