From: Thiemo Seufer <ths@networkno.de>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org, qemu-devel@nongnu.org
Subject: Re: [MIPS] Use conditional traps for BUG_ON on MIPS II and better.
Date: Sat, 16 Dec 2006 17:11:43 +0000 [thread overview]
Message-ID: <20061216171142.GA21660@networkno.de> (raw)
In-Reply-To: <20061216.012645.07642903.anemo@mba.ocn.ne.jp>
Atsushi Nemoto wrote:
> On Sun, 3 Dec 2006 21:35:18 +0000, Ralf Baechle <ralf@linux-mips.org> wrote:
> > > It seems this commit break QEMU kernel ... or QEMU can not interpret
> > > the TNE instruction correctly?
> >
> > Thiemo says that's indeed a possibility. Probably that feature has not
> > been well tested in qemu.
>
> I found the bug. "Trap If XXX" instructions are translated as it was
> "Trap If XXX Immediate".
>
> Index: target-mips/translate.c
> ===================================================================
> RCS file: /sources/qemu/qemu/target-mips/translate.c,v
> retrieving revision 1.27
> diff -u -r1.27 translate.c
> --- target-mips/translate.c 10 Dec 2006 22:08:10 -0000 1.27
> +++ target-mips/translate.c 15 Dec 2006 16:16:07 -0000
> @@ -1276,6 +1276,7 @@
> GEN_LOAD_REG_TN(T1, rt);
> cond = 1;
> }
> + break;
> case OPC_TEQI:
> case OPC_TGEI:
> case OPC_TGEIU:
Thanks, committed.
Thiemo
WARNING: multiple messages have this Message-ID (diff)
From: Thiemo Seufer <ths@networkno.de>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-mips@linux-mips.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [MIPS] Use conditional traps for BUG_ON on MIPS II and better.
Date: Sat, 16 Dec 2006 17:11:43 +0000 [thread overview]
Message-ID: <20061216171142.GA21660@networkno.de> (raw)
In-Reply-To: <20061216.012645.07642903.anemo@mba.ocn.ne.jp>
Atsushi Nemoto wrote:
> On Sun, 3 Dec 2006 21:35:18 +0000, Ralf Baechle <ralf@linux-mips.org> wrote:
> > > It seems this commit break QEMU kernel ... or QEMU can not interpret
> > > the TNE instruction correctly?
> >
> > Thiemo says that's indeed a possibility. Probably that feature has not
> > been well tested in qemu.
>
> I found the bug. "Trap If XXX" instructions are translated as it was
> "Trap If XXX Immediate".
>
> Index: target-mips/translate.c
> ===================================================================
> RCS file: /sources/qemu/qemu/target-mips/translate.c,v
> retrieving revision 1.27
> diff -u -r1.27 translate.c
> --- target-mips/translate.c 10 Dec 2006 22:08:10 -0000 1.27
> +++ target-mips/translate.c 15 Dec 2006 16:16:07 -0000
> @@ -1276,6 +1276,7 @@
> GEN_LOAD_REG_TN(T1, rt);
> cond = 1;
> }
> + break;
> case OPC_TEQI:
> case OPC_TGEI:
> case OPC_TGEIU:
Thanks, committed.
Thiemo
next prev parent reply other threads:[~2006-12-16 17:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <S20037651AbWK3BXW/20061130012322Z+10503@ftp.linux-mips.org>
2006-12-03 16:53 ` [MIPS] Use conditional traps for BUG_ON on MIPS II and better Atsushi Nemoto
2006-12-03 21:35 ` Ralf Baechle
2006-12-15 16:26 ` Atsushi Nemoto
2006-12-15 16:26 ` [Qemu-devel] " Atsushi Nemoto
2006-12-16 17:11 ` Thiemo Seufer [this message]
2006-12-16 17:11 ` Thiemo Seufer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061216171142.GA21660@networkno.de \
--to=ths@networkno.de \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
--cc=qemu-devel@nongnu.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.