All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: David Miller <davem@davemloft.net>
Cc: adobriyan@gmail.com, netdev@vger.kernel.org,
	webmaster@programmierforen.de, kernel-janitors@lists.osdl.org
Subject: [KJ] [2.6 patch] drivers/atm/he.c: remove ancient version string
Date: Mon, 18 Dec 2006 04:50:03 +0000	[thread overview]
Message-ID: <20061218045003.GD10316@stusta.de> (raw)
In-Reply-To: <20061217.171159.32723537.davem@davemloft.net>

On Sun, Dec 17, 2006 at 05:11:59PM -0800, David Miller wrote:
> From: Alexey Dobriyan <adobriyan@gmail.com>
> Date: Sun, 17 Dec 2006 15:56:22 +0300
> 
> > From: Andi Drebes <webmaster@programmierforen.de>
> > 
> >    text    data     bss     dec     hex filename
> >   20015     480      28   20523    502b drivers/atm/he.o
> >   19997     480      28   20505    5019 drivers/atm/he.o
> > 
> > Signed-off-by: Andi Drebes <webmaster@programmierforen.de>
> > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> 
> As Adrian said, this CVS string is totally useless.
> 
> That being said, it should be replaced with an
> appropriate piece of versioning information, like
> the ones we use via MODULE_VERSION() in other drivers.

Which versioning information?

There does not seem to be any versioning information that is 
getting updated.

There are some truly exceptional cases where maintainers are using and 
updating version strings, but in all other cases there's simply nothing 
that's worth being printed.

> I'll be happy to apply a patch which gets rid of the
> CVS references, and replaces it with something useful.

Patch below.

> Thanks.

cu
Adrian


<--  snip  -->


This patch removes the ancient version string.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/atm/he.c |   10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

--- linux-2.6.20-rc1-mm1/drivers/atm/he.c.old	2006-12-18 05:35:19.000000000 +0100
+++ linux-2.6.20-rc1-mm1/drivers/atm/he.c	2006-12-18 05:39:40.000000000 +0100
@@ -1,5 +1,3 @@
-/* $Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $ */
-
 /*
 
   he.c
@@ -99,10 +97,6 @@
 #define HPRINTK(fmt,args...)	do { } while (0)
 #endif /* HE_DEBUG */
 
-/* version definition */
-
-static char *version = "$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $";
-
 /* declarations */
 
 static int he_open(struct atm_vcc *vcc);
@@ -366,7 +360,7 @@ he_init_one(struct pci_dev *pci_dev, con
 	struct he_dev *he_dev = NULL;
 	int err = 0;
 
-	printk(KERN_INFO "he: %s\n", version);
+	printk(KERN_INFO "ATM he driver\n");
 
 	if (pci_enable_device(pci_dev))
 		return -EIO;
@@ -2933,7 +2927,7 @@ he_proc_read(struct atm_dev *dev, loff_t
 
 	left = *pos;
 	if (!left--)
-		return sprintf(page, "%s\n", version);
+		return sprintf(page, "ATM he driver\n");
 
 	if (!left--)
 		return sprintf(page, "%s%s\n\n",

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

WARNING: multiple messages have this Message-ID (diff)
From: Adrian Bunk <bunk@stusta.de>
To: David Miller <davem@davemloft.net>
Cc: adobriyan@gmail.com, netdev@vger.kernel.org,
	webmaster@programmierforen.de, kernel-janitors@lists.osdl.org
Subject: [2.6 patch] drivers/atm/he.c: remove ancient version string
Date: Mon, 18 Dec 2006 05:50:03 +0100	[thread overview]
Message-ID: <20061218045003.GD10316@stusta.de> (raw)
In-Reply-To: <20061217.171159.32723537.davem@davemloft.net>

On Sun, Dec 17, 2006 at 05:11:59PM -0800, David Miller wrote:
> From: Alexey Dobriyan <adobriyan@gmail.com>
> Date: Sun, 17 Dec 2006 15:56:22 +0300
> 
> > From: Andi Drebes <webmaster@programmierforen.de>
> > 
> >    text    data     bss     dec     hex filename
> >   20015     480      28   20523    502b drivers/atm/he.o
> >   19997     480      28   20505    5019 drivers/atm/he.o
> > 
> > Signed-off-by: Andi Drebes <webmaster@programmierforen.de>
> > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> 
> As Adrian said, this CVS string is totally useless.
> 
> That being said, it should be replaced with an
> appropriate piece of versioning information, like
> the ones we use via MODULE_VERSION() in other drivers.

Which versioning information?

There does not seem to be any versioning information that is 
getting updated.

There are some truly exceptional cases where maintainers are using and 
updating version strings, but in all other cases there's simply nothing 
that's worth being printed.

> I'll be happy to apply a patch which gets rid of the
> CVS references, and replaces it with something useful.

Patch below.

> Thanks.

cu
Adrian


<--  snip  -->


This patch removes the ancient version string.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/atm/he.c |   10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

--- linux-2.6.20-rc1-mm1/drivers/atm/he.c.old	2006-12-18 05:35:19.000000000 +0100
+++ linux-2.6.20-rc1-mm1/drivers/atm/he.c	2006-12-18 05:39:40.000000000 +0100
@@ -1,5 +1,3 @@
-/* $Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $ */
-
 /*
 
   he.c
@@ -99,10 +97,6 @@
 #define HPRINTK(fmt,args...)	do { } while (0)
 #endif /* HE_DEBUG */
 
-/* version definition */
-
-static char *version = "$Id: he.c,v 1.18 2003/05/06 22:57:15 chas Exp $";
-
 /* declarations */
 
 static int he_open(struct atm_vcc *vcc);
@@ -366,7 +360,7 @@ he_init_one(struct pci_dev *pci_dev, con
 	struct he_dev *he_dev = NULL;
 	int err = 0;
 
-	printk(KERN_INFO "he: %s\n", version);
+	printk(KERN_INFO "ATM he driver\n");
 
 	if (pci_enable_device(pci_dev))
 		return -EIO;
@@ -2933,7 +2927,7 @@ he_proc_read(struct atm_dev *dev, loff_t
 
 	left = *pos;
 	if (!left--)
-		return sprintf(page, "%s\n", version);
+		return sprintf(page, "ATM he driver\n");
 
 	if (!left--)
 		return sprintf(page, "%s%s\n\n",


  reply	other threads:[~2006-12-18  4:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-17 12:56 [KJ] [PATCH] he: tiny space savings Alexey Dobriyan
2006-12-17 12:56 ` Alexey Dobriyan
2006-12-17 18:28 ` [KJ] " Adrian Bunk
2006-12-17 18:28   ` Adrian Bunk
2006-12-17 20:02   ` Alexey Dobriyan
2006-12-17 20:02     ` Alexey Dobriyan
2006-12-17 20:06     ` Adrian Bunk
2006-12-17 20:06       ` Adrian Bunk
2006-12-18  1:11 ` David Miller
2006-12-18  1:11   ` David Miller
2006-12-18  4:50   ` Adrian Bunk [this message]
2006-12-18  4:50     ` [2.6 patch] drivers/atm/he.c: remove ancient version string Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061218045003.GD10316@stusta.de \
    --to=bunk@stusta.de \
    --cc=adobriyan@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=netdev@vger.kernel.org \
    --cc=webmaster@programmierforen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.